../../dist/include/mozilla/dom/BlobSet.h:42:20: error: 'Blob' was not declared in this scope

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: gerard-majax, Assigned: baku)

Tracking

unspecified
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(firefox50 fixed)

Details

Attachments

(2 attachments)

Comment hidden (empty)
(Reporter)

Comment 1

3 years ago
In file included from ../../../../../../../gecko-cinnabar/dom/bluetooth/common/webapi/BluetoothPbapRequestHandle.h:13:0,
                 from ../../../../../../../gecko-cinnabar/dom/bluetooth/common/webapi/BluetoothPbapRequestHandle.cpp:8:
../../dist/include/mozilla/dom/BlobSet.h:42:20: error: 'Blob' was not declared in this scope
   already_AddRefed<Blob> GetBlobInternal(nsISupports* aParent,
                    ^
../../dist/include/mozilla/dom/BlobSet.h:42:20: note: suggested alternatives:
In file included from ../../dist/include/mozilla/dom/DOMJSClass.h:15:0,
                 from ../../dist/include/mozilla/dom/BindingUtils.h:21,
                 from ../../dist/include/mozilla/dom/ToJSValue.h:12,
                 from ../../dist/include/mozilla/dom/EventListenerBinding.h:12,
                 from ../../dist/include/mozilla/EventListenerManager.h:11,
                 from ../../dist/include/mozilla/DOMEventTargetHelper.h:19,
                 from ../../dist/include/mozilla/dom/DOMRequest.h:12,
                 from ../../../../../../../gecko-cinnabar/dom/bluetooth/common/webapi/BluetoothPbapRequestHandle.h:12,
                 from ../../../../../../../gecko-cinnabar/dom/bluetooth/common/webapi/BluetoothPbapRequestHandle.cpp:8:
../../dist/include/mozilla/dom/PrototypeList.h:52:3: note:   'Blob'
   Blob,
   ^
../../dist/include/mozilla/dom/PrototypeList.h:951:3: note:   'Blob'
   Blob,
   ^
In file included from ../../../../../../../gecko-cinnabar/dom/bluetooth/common/webapi/BluetoothPbapRequestHandle.h:13:0,
                 from ../../../../../../../gecko-cinnabar/dom/bluetooth/common/webapi/BluetoothPbapRequestHandle.cpp:8:
../../dist/include/mozilla/dom/BlobSet.h:42:24: error: template argument 1 is invalid
(Reporter)

Updated

3 years ago
Blocks: 1281748
(Assignee)

Comment 2

3 years ago
Created attachment 8765613 [details] [diff] [review]
blobset1.patch
Assignee: nobody → amarchesini
Attachment #8765613 - Flags: review?(lissyx+mozillians)
(Reporter)

Comment 3

3 years ago
Created attachment 8765618 [details]
Bug 1282571 - Followup of 1281748 Remove BlobSet.h

Review commit: https://reviewboard.mozilla.org/r/60902/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/60902/
Attachment #8765618 - Flags: review?(amarchesini)
(Reporter)

Comment 4

3 years ago
Oops patch collision. I'm testing yours.
(Reporter)

Comment 5

3 years ago
Comment on attachment 8765613 [details] [diff] [review]
blobset1.patch

It's not working :/

In file included from ../../dist/include/nsISupportsUtils.h:15:0,
                 from ../../dist/include/nsISupports.h:130,
                 from ../../dist/include/nsCycleCollectionTraversalCallback.h:11,
                 from ../../dist/include/nsCycleCollectionNoteChild.h:13,
                 from ../../dist/include/nsTArray.h:25,
                 from ../../dist/include/mozilla/Observer.h:10,
                 from ../../../../../../../gecko-cinnabar/dom/bluetooth/common/BluetoothCommon.h:13,
                 from ../../../../../../../gecko-cinnabar/dom/bluetooth/common/webapi/BluetoothPbapRequestHandle.cpp:7:
../../dist/include/mozilla/RefPtr.h: In instantiation of 'static void mozilla::RefPtrTraits<U>::Release(U*) [with U = mozilla::dom::BlobImpl]':
../../dist/include/mozilla/RefPtr.h:377:45:   required from 'static void RefPtr<T>::ConstRemovingRefPtrTraits<U>::Release(U*) [with U = mozilla::dom::BlobImpl; T = mozilla::dom::BlobImpl]'
../../dist/include/mozilla/RefPtr.h:77:52:   required from 'RefPtr<T>::~RefPtr() [with T = mozilla::dom::BlobImpl]'
../../dist/include/nsTArray.h:523:40:   required from 'static void nsTArrayElementTraits<E>::Destruct(E*) [with E = RefPtr<mozilla::dom::BlobImpl>]'
../../dist/include/nsTArray.h:2014:33:   required from 'void nsTArray_Impl<E, Alloc>::DestructRange(nsTArray_Impl<E, Alloc>::index_type, nsTArray_Impl<E, Alloc>::size_type) [with E = RefPtr<mozilla::dom::BlobImpl>; Alloc = nsTArrayInfallibleAllocator; nsTArray_Impl<E, Alloc>::index_type = unsigned int; nsTArray_Impl<E, Alloc>::size_type = unsigned int]'
../../dist/include/nsTArray.h:1656:33:   required from 'void nsTArray_Impl<E, Alloc>::RemoveElementsAt(nsTArray_Impl<E, Alloc>::index_type, nsTArray_Impl<E, Alloc>::size_type) [with E = RefPtr<mozilla::dom::BlobImpl>; Alloc = nsTArrayInfallibleAllocator; nsTArray_Impl<E, Alloc>::index_type = unsigned int; nsTArray_Impl<E, Alloc>::size_type = unsigned int]'
../../dist/include/nsTArray.h:1666:46:   required from 'void nsTArray_Impl<E, Alloc>::Clear() [with E = RefPtr<mozilla::dom::BlobImpl>; Alloc = nsTArrayInfallibleAllocator]'
../../dist/include/nsTArray.h:828:28:   required from 'nsTArray_Impl<E, Alloc>::~nsTArray_Impl() [with E = RefPtr<mozilla::dom::BlobImpl>; Alloc = nsTArrayInfallibleAllocator]'
../../dist/include/nsTArray.h:2088:7:   required from here
../../dist/include/mozilla/RefPtr.h:39:5: error: invalid use of incomplete type 'class mozilla::dom::BlobImpl'
     aPtr->Release();
     ^
In file included from ../../../../../../../gecko-cinnabar/dom/bluetooth/common/webapi/BluetoothPbapRequestHandle.h:13:0,
                 from ../../../../../../../gecko-cinnabar/dom/bluetooth/common/webapi/BluetoothPbapRequestHandle.cpp:8:
../../dist/include/mozilla/dom/BlobSet.h:16:7: error: forward declaration of 'class mozilla::dom::BlobImpl'
 class BlobImpl;
Attachment #8765613 - Flags: review?(lissyx+mozillians)
(Reporter)

Comment 6

3 years ago
Andrea, attachment 8765618 [details] builds and boots for me
Flags: needinfo?(amarchesini)
(Assignee)

Comment 7

3 years ago
Comment on attachment 8765618 [details]
Bug 1282571 - Followup of 1281748 Remove BlobSet.h

https://reviewboard.mozilla.org/r/60902/#review57798
Attachment #8765618 - Flags: review?(amarchesini) → review+
(Assignee)

Comment 8

3 years ago
But also my patch needs to land. We use 'Blob' without defining it anywhere in this header.
Flags: needinfo?(amarchesini)
(Reporter)

Comment 9

3 years ago
Comment on attachment 8765618 [details]
Bug 1282571 - Followup of 1281748 Remove BlobSet.h

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/60902/diff/1-2/
(Reporter)

Comment 10

3 years ago
(In reply to Andrea Marchesini (:baku) from comment #8)
> But also my patch needs to land. We use 'Blob' without defining it anywhere
> in this header.

Sure, added it :)

Comment 11

3 years ago
Pushed by alissy@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/464953b5963e
Followup of 1281748 Remove BlobSet.h r=baku

Comment 12

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/464953b5963e
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.