Closed Bug 1282643 Opened 4 years ago Closed 4 years ago

[css-grid] Reject repeat() column tracks in <grid-template> when there's a grid template area string in the row part

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox50 --- affected
firefox51 --- fixed

People

(Reporter: mats, Assigned: mats)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

It appears the 'grid-template' syntax no longer allows repeat() column tracks
if there a is a grid template area string in the row part:
https://drafts.csswg.org/css-grid/#grid-template-ascii

[ <line-names>? <string> <track-size>? <line-names>? ]+ [ / <explicit-track-list> ]?

<explicit-track-list> = [ <line-names>? <track-size> ]+ <line-names>?

https://hg.csswg.org/drafts/rev/de8ef74e4048
Here's some more background:

  - Tentatively the group resolved that auto-repeat should be
      invalid despite existing implementations. And remove the
      grammar that allows repeat() for columns as it was an accident.
      - If there are no objections on the mailing list before the
          next telecon, the group will formally resolve.

https://lists.w3.org/Archives/Public/www-style/2016May/0231.html

The problem was originally reported by Rego:
https://lists.w3.org/Archives/Public/www-style/2016May/0193.html
Comment on attachment 8766555 [details] [diff] [review]
fix+tests

Review of attachment 8766555 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good -- r=me
Attachment #8766555 - Flags: review?(dholbert) → review+
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a72342d3ad90
[css-grid] Reject repeat() column tracks in <grid-template> when there's a grid template area string in the row part.  r=dholbert
https://hg.mozilla.org/mozilla-central/rev/a72342d3ad90
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.