1282655 - Add a test case to test whether site permissions are universal or isolated for each type of OriginAttribute

Status: RESOLVED FIXED

(Core :: DOM: Security, defect, P2)

Description

[Tim Huang[:timhuang]]

We need a mochitest to make sure that all containers share the same site permissions.

Comment 1

[Ethan Tseng [:ethan]]

Jonathan already wrote xpcshell tests for permissions in bug 1301617. We are going to implement mochitest in this bug.

Comment 2

[Ethan Tseng [:ethan]]

Jonathan, when you have spare cycle, please take a look to see if you can provide a mochitest here.

Comment 3

[Jonathan Hao (inactive) [:jhao]]

Attachment: Test if site permissions are universal across origin attributes.

Comment 4

[Tanvi Vyas[:tanvi]]

Hi Jonathan,

This test looks like it is about cookie settings rather than permission settings.  Is this the wrong test, or am I missing something - i.e. are permissions stored internally in a cookie?

Comment 5

[Jonathan Hao (inactive) [:jhao]]

(In reply to Tanvi Vyas [:tanvi] from comment #4)
> Hi Jonathan,
> 
> This test looks like it is about cookie settings rather than permission
> settings.  Is this the wrong test, or am I missing something - i.e. are
> permissions stored internally in a cookie?

Hi Tanvi,

Services.perms.add is actually just an nsIPermissionManager.add().  Or is it not the kind of test you had in mind?

Comment 6

[Tanvi Vyas[:tanvi]]

Comment on attachment 8816416 [details] [diff] [review]
Test if site permissions are universal across origin attributes.

>+++ b/browser/components/originattributes/test/browser/browser_permissions.js
>@@ -0,0 +1,45 @@
>+const TEST_PAGE = "http://example.net";
>+const uri = Services.io.newURI(TEST_PAGE, null, null);
>+

Add a comment indicating that this test is testing the cookie "permission" for a specific URI.

>+function disableCookies() {
>+  Services.cookies.removeAll();
>+  Services.perms.add(uri, "cookie", Services.perms.DENY_ACTION);
>+}
>+
>+function ensureCookieNotSet(aBrowser) {
>+  dump("JONATHAN: " + Services.perms.testPermission(uri, "cookie") + "\n");
Remove dump

>+  ContentTask.spawn(aBrowser, null, function*() {
>+    content.document.cookie = "key=value";
>+    is(content.document.cookie, "",
>+       "Cookies should be disabled for all origin attributes");
Change to something like this:
"Setting/reading cookies should be disabled for this domain for all origin attribute combinations."
>+  });
>+}
>+
>+IsolationTestTools.runTests(TEST_PAGE, ensureCookieNotSet, () => true,
>+                            disableCookies);
>+
>+add_task(function* () {
>+  Services.cookies.removeAll();
>+  Services.perms.add(uri, "cookie", Services.perms.ALLOW_ACTION);
>+  dump("JONATHAN: task done\n");
>+});
What is this task for?  Just to clean up before the next test?  enableCookies() does the same thing though.
Please remove the dump.

>+
>+function enableCookies() {
>+  Services.cookies.removeAll();
>+  Services.perms.add(uri, "cookie", Services.perms.ALLOW_ACTION);
>+}
>+
>+function ensureCookieSet(aBrowser) {
>+  ContentTask.spawn(aBrowser, null, function() {
>+    content.document.cookie = "key=value";
>+    is(content.document.cookie, "key=value",
>+       "Cookies should be enabled for all origin attributes");
"Setting/reading cookies should be enabled for this domain for all origin attribute combinations."

>+  });
>+}
>+
>+IsolationTestTools.runTests(TEST_PAGE, ensureCookieSet, () => true,
>+                            enableCookies);
>+
>+registerCleanupFunction(() => {
>+    Services.cookies.removeAll();
>+});
>

Comment 7

[Jonathan Hao (inactive) [:jhao]]

Attachment: Test if site permissions are universal across origin attributes.

Thanks, Tanvi.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/330262e55c87
Test if site permissions are universal across origin attributes. r=tanvi

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/330262e55c87