Closed
Bug 1301617
Opened 8 years ago
Closed
test for firstParty and userContextId documents with nsIPermissionManager
Categories
(Core :: DOM: Security, defect, P3)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: allstars.chh, Assigned: jhao)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [OA-testing][domsecurity-backlog1][tor-testing])
Attachments
(1 file)
7.05 KB,
patch
|
baku
:
review+
allstars.chh
:
feedback+
|
Details | Diff | Splinter Review |
In Bug 1280497, 1233885 and Bug 1301274 we use default value for userContextId and firstPartyDomain, so the page could still use the same permission.
Said, for documents whose nodePrincipal are
- https://example.com^firstPartyDomain=example.com
- https://example.com^userContextId=1
- https://example.com^userContextId=1&firstPartyDomain=example.com
They could still use the same permission with
"https://example.com"
So we should have a test for this.
Updated•8 years ago
|
Depends on: ContextualIdentity
Whiteboard: [OA-testing][domsecurity-backlog1] → [OA-testing][domsecurity-backlog1][tor-testing]
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → jhao
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•8 years ago
|
||
I added some unit tests about nsIPermissionManager. Yoshi, do you think we also need integration tests (browser mochitests)?
Attachment #8790144 -
Flags: feedback?(allstars.chh)
Reporter | ||
Comment 2•8 years ago
|
||
Comment on attachment 8790144 [details] [diff] [review]
Tests for firstPartyDomain and userContextId with nsIPermissionManager.
Review of attachment 8790144 [details] [diff] [review]:
-----------------------------------------------------------------
Perhaps we could add some tests in
extensions/cookie/test/unit/test_permmanager_matches.js
extensions/cookie/test/unit/test_permmanager_matchesuri.js
to verify your comment https://bugzilla.mozilla.org/show_bug.cgi?id=1301274#c6
I am okay if we only have unit test right now, and focus on other isolation tests first.
But if you already have a patch, it's even better.
Attachment #8790144 -
Flags: feedback?(allstars.chh) → feedback+
Assignee | ||
Comment 3•8 years ago
|
||
Comment on attachment 8790144 [details] [diff] [review]
Tests for firstPartyDomain and userContextId with nsIPermissionManager.
Thanks, Yoshi. I opened bug 1301274 for permission matches.
Baku, would you also review these tests please?
Attachment #8790144 -
Flags: review?(amarchesini)
Updated•8 years ago
|
Attachment #8790144 -
Flags: review?(amarchesini) → review+
Updated•8 years ago
|
Blocks: ContextualIdentity
No longer depends on: ContextualIdentity
Updated•8 years ago
|
Priority: -- → P3
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 4•8 years ago
|
||
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/791d2d978ef7
Add tests for firstPartyDomain and userContextId with nsIPermissionManager. r=baku
Keywords: checkin-needed
Comment 6•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Comment 7•8 years ago
|
||
bugherder |
Closed: 8 years ago → 8 years ago
You need to log in
before you can comment on or make changes to this bug.
Description
•