1301617 - test for firstParty and userContextId documents with nsIPermissionManager

Status: RESOLVED FIXED

(Core :: DOM: Security, defect, P3)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh]]

In Bug 1280497, 1233885 and Bug 1301274 we use default value for userContextId and firstPartyDomain, so the page could still use the same permission.

Said, for documents whose nodePrincipal are
- https://example.com^firstPartyDomain=example.com
- https://example.com^userContextId=1
- https://example.com^userContextId=1&firstPartyDomain=example.com

They could still use the same permission with
"https://example.com"

So we should have a test for this.

Comment 1

[Jonathan Hao (inactive) [:jhao]]

Attachment: Tests for firstPartyDomain and userContextId with nsIPermissionManager.

I added some unit tests about nsIPermissionManager.  Yoshi, do you think we also need integration tests (browser mochitests)?

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh]]

Comment on attachment 8790144 [details] [diff] [review]
Tests for firstPartyDomain and userContextId with nsIPermissionManager.

Review of attachment 8790144 [details] [diff] [review]:
-----------------------------------------------------------------

Perhaps we could add some tests in 
extensions/cookie/test/unit/test_permmanager_matches.js
extensions/cookie/test/unit/test_permmanager_matchesuri.js 

to verify your comment https://bugzilla.mozilla.org/show_bug.cgi?id=1301274#c6

I am okay if we only have unit test right now, and focus on other isolation tests first.
But if you already have a patch, it's even better.

Comment 3

[Jonathan Hao (inactive) [:jhao]]

Comment on attachment 8790144 [details] [diff] [review]
Tests for firstPartyDomain and userContextId with nsIPermissionManager.

Thanks, Yoshi.  I opened bug 1301274 for permission matches.

Baku, would you also review these tests please?

Comment 4

[Jonathan Hao (inactive) [:jhao]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=46e657d6a3be&selectedJob=27915448

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/791d2d978ef7
Add tests for firstPartyDomain and userContextId with nsIPermissionManager. r=baku

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/791d2d978ef7

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/791d2d978ef7