Closed Bug 1282927 Opened 4 years ago Closed 4 years ago

Port recent package-manifest.in changes to Seamonkey

Categories

(SeaMonkey :: Installer, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: frg, Assigned: frg)

References

Details

Attachments

(1 file, 2 obsolete files)

Bug 1221730 and bug 1269162 needs changes in package-manifest.in
Attached patch 1282927-installer.patch (obsolete) — Splinter Review
Patch for installer breakage. Need to check if MOZ_GAMEPAD still does something.
Assignee: installer → frgrahl
Status: NEW → ASSIGNED
Attachment #8766054 - Flags: review?(philip.chee)
Added bug 1283825 which should be in c-c tomorrow.
Depends on: 1221730, 1269162, 1283825
Summary: Port bug 1221730 and bug 1269162 to Seamonkeys package-manifest.in → Port recent package-manifest.in changes to Seamonkey
Attached patch 1282927-installer-V2.patch (obsolete) — Splinter Review
Added Bug 1283825 to patch
Attachment #8766054 - Attachment is obsolete: true
Attachment #8766054 - Flags: review?(philip.chee)
Attachment #8767773 - Flags: review?(philip.chee)
(In reply to Frank-Rainer Grahl from comment #3)
> Created attachment 8767773 [details] [diff] [review]
> 1282927-installer-V2.patch
> 
> Added Bug 1283825 to patch

Now that they've removed the error console, even with this
patch, we're busted; but that'd be covered by bug 1282286.
Comment on attachment 8767773 [details] [diff] [review]
1282927-installer-V2.patch

Review of attachment 8767773 [details] [diff] [review]:
-----------------------------------------------------------------

stealing review...  lgtm
Attachment #8767773 - Flags: review?(philip.chee) → review+
>> stealing review...  lgtm

A little too fast. Thought I had time till Ratty returns :) aleth pushed a patch to all c-c packages without bug number in https://bugzilla.mozilla.org/show_bug.cgi?id=1283825.

https://hg.mozilla.org/comm-central/rev/6181b27529a957ef55ee7e183ef6ce40c891ff14

Don't want to backout a one liner so here is an updated patch.

review+ from ewong carried forward.
Attachment #8767773 - Attachment is obsolete: true
Attachment #8769416 - Flags: review+
Done. Keeping the reference to Bug 1283825 for documentation here.

https://hg.mozilla.org/comm-central/rev/718577ecc9e6
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.