1283825 - Add a page-icon protocol to fetch the best icon for a url

Status: RESOLVED FIXED

(Toolkit :: Places, defect, P1)

Description

[Marco Bonardo [:mak]]

Having multiple icons per page complicates joining the tables, but often the only reason to select the icon is to show it in the ui through moz-anno:favicon:iconurl.
By having a page-icon:pageurl protocol, we could avoid the db joins and directly show the icon only by knowing the page url.

Comment 1

[Marco Bonardo [:mak]]

Attachment: Bug 1283825 - Add a page-icon protocol to fetch the best icon for a url.

Review commit: https://reviewboard.mozilla.org/r/61800/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61800/

Comment 2

[Drew Willcoxon :adw]

Comment on attachment 8767134 [details]
Bug 1283825 - Add a page-icon protocol to fetch the best icon for a url.

https://reviewboard.mozilla.org/r/61800/#review58642

Comment 3

[Marco Bonardo [:mak]]

just as a side note, this is a first implementation that just pulls out the favicon for a specific page url, in the future I think we will change this to:
- be able to specify a preferred size in the url itself, to get the crispier icon based on that
- return a known icon for the same domain when the icon for the requested page is unknown, this will give us more favicons and cover autofill in the awesomebar. Maybe it should be an option in the url, maybe not, this is something to test out.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/a46d234975d9
Add a page-icon protocol to fetch the best icon for a url. r=adw

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/a46d234975d9

Comment 6

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/6181b27529a957ef55ee7e183ef6ce40c891ff14
Add PageIconProtocolHandler.js to package-manifest (Bug 1283825). rs=bustage-fix a=aleth