1283022 - Implement the min and max attribute for <input type=month>

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Comment 1

[Jessica Jong [:jessica] (inactive)]

Attachment: patch, v1.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8771265 [details] [diff] [review]
patch, v1.

>+    case 'month':
>+      input.value = '2016-06';
>+      checkValidity(input, true, apply, apply);
>+
>+      input.value = '2016-12';
>+      checkValidity(input, true, apply, apply);
>+
>+      input.value = 'foo';
>+      checkValidity(input, true, apply, apply);
It always surprises me how invalid values are handled when one assigns such to .value (.value becomes "" after assigning "foo", right?);

Comment 3

[Jessica Jong [:jessica] (inactive)]

(In reply to Olli Pettay [:smaug] from comment #2)
> Comment on attachment 8771265 [details] [diff] [review]
> patch, v1.
> 
> >+    case 'month':
> >+      input.value = '2016-06';
> >+      checkValidity(input, true, apply, apply);
> >+
> >+      input.value = '2016-12';
> >+      checkValidity(input, true, apply, apply);
> >+
> >+      input.value = 'foo';
> >+      checkValidity(input, true, apply, apply);
> It always surprises me how invalid values are handled when one assigns such
> to .value (.value becomes "" after assigning "foo", right?);

Right, if the value is not a valid month string, we set it to the empty string instead.

Comment 4

[Jessica Jong [:jessica] (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eac414a3cbf9

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/564fdbb916ba
Implement the min and max attribute for <input type=month>. r=smaug

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/564fdbb916ba