Closed
Bug 1283037
Opened 8 years ago
Closed 8 years ago
Enable Cipher tests on LSan runs
Categories
(NSS :: Libraries, defect)
NSS
Libraries
Tracking
(Not tracked)
RESOLVED
FIXED
3.26
People
(Reporter: ttaubert, Assigned: ttaubert)
References
Details
Attachments
(1 file)
|
13.72 KB,
patch
|
franziskus
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•8 years ago
|
Component: Build → Libraries
|
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8766228 -
Flags: review?(franziskuskiefer)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8766228 [details] [diff] [review]
0001-Bug-1283037-Enable-Cipher-tests-on-LSan-runs.patch
Review of attachment 8766228 [details] [diff] [review]:
-----------------------------------------------------------------
::: cmd/bltest/blapitest.c
@@ +3287,5 @@
> rv |= verify_self_test(&cipherInfo.output,
> &pt, mode, PR_FALSE, srv);
> }
> }
> + PORT_FreeArena(arena, PR_FALSE);
don't you want PR_TRUE here?
Attachment #8766228 -
Flags: review?(franziskuskiefer) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
(In reply to Franziskus Kiefer [:fkiefer or :franziskus] from comment #2)
> > + PORT_FreeArena(arena, PR_FALSE);
>
> don't you want PR_TRUE here?
The second argument here only specifies whether we want the memory zeroed or not, you're probably confusing it with SECItem_FreeItem() where the second arg specifies whether the item itself will be freed :) The arena always is.
|
|
Assignee | |
Comment 4•8 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•8 years ago
|
Target Milestone: --- → 3.26
You need to log in
before you can comment on or make changes to this bug.
Description
•