1246801 - Leak Sanitizer (LSan) support for NSS

Status: RESOLVED FIXED

(NSS :: Build, defect, P2)

Description

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Bug 1233568 will enable Address Sanitizer support for NSS, for detecting use-after-free and buffer-overrun bugs and such, but disables the accompanying memory leak checker.  Enabling it will require going through the leaks reported in the test suite, deciding which ones are real bugs that need to be fixed, and either fixing them or (if not simple to fix) filing bugs and adding suppressions pending a fix, as well as suppressing any considered to be false positives.

Comment 1

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Some of this work has already been done — tests/memleak/ignored should at least be a starting point for a suppression list for LSan.  Firefox also has an LSan suppression file, but it doesn't have much from NSS or NSPR.

Comment 2

[Andrew McCreight [:mccr8]]

local_suppressor.py from https://github.com/amccreight/mochitest-logs is useful when trying to build up a suppression list to cover a particular run. It attempts to simulate which leaking stacks would be suppressed with a given suppression file.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0003-Bug-1246801-Disable-tail-call-elimination-when-runni.patch

http://clang.llvm.org/docs/AddressSanitizer.html proposes to disable tail call elimination for better stack traces.

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0004-Bug-1246801-Allow-to-selectively-enable-LSan.patch

This patch adds NSS_ENABLE_LSAN, a runtime flag that allows to leave LSan enabled. We need it to switch on LSan for selected builds/tests until all leaks are fixed.

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0009-Bug-1246801-Add-LSan-builds-to-Taskcluster.patch

This would use the new NSS_ENABLE_LSAN flag and create a new "lsan" row on TreeHerder, until we can merge ASan and ASan/LSan back together. For a start, we get a build and a cert.sh run with that.

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/projects/nss/rev/6c5f450d6230
https://hg.mozilla.org/projects/nss/rev/3b37387c214c
https://hg.mozilla.org/projects/nss/rev/bc84de92fd16

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-1246801-Set-NSS_DISABLE_ARENA_FREE_LIST-1-for-LS.patch

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0009-Bug-1246801-Add-Gtests-to-LSan-test-runs.patch

Comment 10

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/projects/nss/rev/e95e849daefd
https://hg.mozilla.org/projects/nss/rev/7fd7753dd2a9

Comment 11

[Tim Taubert [:ttaubert] (inactive)]

Enabling ocsp tests:

https://hg.mozilla.org/projects/nss/rev/db127467b4b1

Comment 12

[Tim Taubert [:ttaubert] (inactive)]

Enabling lowhash, pkits, sdr tests:

https://hg.mozilla.org/projects/nss/rev/017961acef77

Comment 13

[Tim Taubert [:ttaubert] (inactive)]

Set NSS_DISABLE_UNLOAD=1 for LSan runs:

https://hg.mozilla.org/projects/nss/rev/9e0b4530a2ea

Comment 14

[Tim Taubert [:ttaubert] (inactive)]

Use docker image v0.0.17, use clang-3.8 for ASan/LSan runs:

https://hg.mozilla.org/projects/nss/rev/b2730e41497e

Comment 15

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/projects/nss/rev/edfe0a84de69

Comment 16

[Firefox Bug Husbandry Bot]

Removing leave-open keyword from resolved bugs, per :sylvestre.