1283056 - Intermittent 876024-1.html | application terminated with exit code 5 | Assertion failure: (mAudioContextState == AudioContextState::Suspended && aNewState == AudioContextState::Running) || (mAudioContextState == AudioContextState::Running && aNewState ==

Status: REOPENED

(Core :: Web Audio, defect, P3)

Description

[Carsten Book [:Tomcat]]

https://treeherder.mozilla.org/logviewer.html#?job_id=79129&repo=autoland#L9257

 02:40:51 INFO - Assertion failure: (mAudioContextState == AudioContextState::Suspended && aNewState == AudioContextState::Running) || (mAudioContextState == AudioContextState::Running && aNewState == AudioContextState::Suspended) || (mAudioContextState == AudioContextState::Running && aNewState == AudioContextState::Closed) || (mAudioContextState == AudioContextState::Suspended && aNewState == AudioContextState::Closed) || (mAudioContextState == aNewState) (Invalid AudioContextState transition), at /builds/slave/autoland-m64-d-000000000000000/build/src/dom/media/webaudio/AudioContext.cpp:854

 02:46:22 WARNING - TEST-UNEXPECTED-FAIL | file:///builds/slave/test/build/tests/reftest/tests/dom/media/test/crashtests/876024-1.html | application terminated with exit code 5

Comment 1

[Karl Tomlinson (:karlt)]

http://searchfox.org/mozilla-central/rev/261fe13dcd88cfd2e99e65755e7ca4b7a2e583df/dom/media/webaudio/AudioContext.cpp#854

Comment 2

[Paul Adenot (:padenot)]

I'm probably going to write some code so that it's more obvious what's happening here.

Comment 3

[Paul Adenot (:padenot)]

Attachment: Bug 1283056 - Print the invalid state transition before crashing on the assert in AudioContext::OnStateChange.

Review commit: https://reviewboard.mozilla.org/r/61772/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61772/

Comment 4

[Intermittent Failures Robot]

18 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 8
* mozilla-inbound: 7
* fx-team: 2
* mozilla-central: 1

Platform breakdown:
* osx-10-10: 18

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1283056&startday=2016-06-27&endday=2016-07-03&tree=all

Comment 5

[Karl Tomlinson (:karlt)]

Comment on attachment 8767067 [details]
Bug 1283056 - Print the invalid state transition before crashing on the assert in AudioContext::OnStateChange.

https://reviewboard.mozilla.org/r/61772/#review58734

::: dom/media/webaudio/AudioContext.cpp:845
(Diff revision 1)
> -  MOZ_ASSERT((mAudioContextState == AudioContextState::Suspended &&
> +  if (!((mAudioContextState == AudioContextState::Suspended &&
> -              aNewState == AudioContextState::Running)   ||
> +       aNewState == AudioContextState::Running)   ||
> -             (mAudioContextState == AudioContextState::Running   &&
> +      (mAudioContextState == AudioContextState::Running   &&
> -              aNewState == AudioContextState::Suspended) ||
> +       aNewState == AudioContextState::Suspended) ||
> -             (mAudioContextState == AudioContextState::Running   &&
> +      (mAudioContextState == AudioContextState::Running   &&
> -              aNewState == AudioContextState::Closed)    ||
> +       aNewState == AudioContextState::Closed)    ||
> -             (mAudioContextState == AudioContextState::Suspended &&
> +      (mAudioContextState == AudioContextState::Suspended &&
> -              aNewState == AudioContextState::Closed)    ||
> +       aNewState == AudioContextState::Closed)    ||
> -             (mAudioContextState == aNewState),
> -             "Invalid AudioContextState transition");
> +      (mAudioContextState == aNewState))) {
> +    fprintf(stderr,
> +            "Invalid transition: mAudioContextState: %d -> aNewState %d\n",
> +            mAudioContextState, aNewState);
> +    MOZ_ASSERT(false);
> +  }

Please put this all in #ifdef DEBUG
(which was previously implied by MOZ_ASSERT).

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/91ff2579f2aa
Print the invalid state transition before crashing on the assert in AudioContext::OnStateChange. r=karlt

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/55eb13faa8e0
Cast the enum to int to fix a bustage on a CLOSED TREE.

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/91ff2579f2aa
https://hg.mozilla.org/mozilla-central/rev/55eb13faa8e0

Comment 9

[Karl Tomlinson (:karlt)]

Orangefactor hasn't seen this failure in 876024-1.html recently, but the bug still shows up in other tests. e.g. bug 1332033.

Comment 10

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

This is an assigned P1 bug without activity in two weeks. 

If you intend to continue working on this bug for the current release/iteration/sprint, remove the 'stale-bug' keyword.

Otherwise we'll reset the priority of the bug back to '--' on Monday, August 28th.

Comment 11

[Bulk Bug Changes for mreavy's org]

Mass change P1->P2 to align with new Mozilla triage process

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information