Closed Bug 1283135 Opened 7 years ago Closed 7 years ago

broken --disable-gamepad: ipc/glue/PBackground.ipdl:16: error: can't locate include file `PGamepadEventChannel.ipdl'

Categories

(Firefox OS Graveyard :: General, defect)

Product:
Firefox OS Graveyard
Component:
General
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1282993

People

(Reporter: gerard-majax, Assigned: gerard-majax)

References

Details

Attachments

(1 file)

Bug 1283135 - Fix gamepad IPDL dependency with no gamepad
58 bytes, text/x-review-board-request
baku
: review+
Details 
fallout from bug 1221730
Reproduced on gonk or when using --disable-gamepad
maybe another usecase for bug 1274518 ?
Depends on: 1274518
Attachment #8766368 - Flags: review?(amarchesini) → review-
Comment on attachment 8766368 [details]
Bug 1283135 - Fix gamepad IPDL dependency with no gamepad

https://reviewboard.mozilla.org/r/61298/#review58168

Instead doing this, what about if you remove: "if CONFIG['MOZ_GAMEPAD']:" from dom/moz.build and change how dom/gamepad/moz.build works?
Comment on attachment 8766368 [details]
Bug 1283135 - Fix gamepad IPDL dependency with no gamepad

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61298/diff/1-2/
Attachment #8766368 - Attachment description: Bug 1283135 - Fix gamepd IPDL dependency with no gamepad → Bug 1283135 - Fix gamepad IPDL dependency with no gamepad
Attachment #8766368 - Flags: review- → review?(amarchesini)
Assignee: nobody → lissyx+mozillians
Comment on attachment 8766368 [details]
Bug 1283135 - Fix gamepad IPDL dependency with no gamepad

https://reviewboard.mozilla.org/r/61298/#review58184

::: dom/gamepad/moz.build:76
(Diff revision 2)
>  ]
>  
>  CFLAGS += CONFIG['GLIB_CFLAGS']
>  CFLAGS += CONFIG['MOZ_DBUS_GLIB_CFLAGS']
>  CXXFLAGS += CONFIG['GLIB_CFLAGS']
>  CXXFLAGS += CONFIG['MOZ_DBUS_GLIB_CFLAGS']

move also from line 66 to 76 into the if()
Attachment #8766368 - Flags: review?(amarchesini) → review+
Comment on attachment 8766368 [details]
Bug 1283135 - Fix gamepad IPDL dependency with no gamepad

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61298/diff/2-3/
Pushed by alissy@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bcd10b16cb33
Fix gamepad IPDL dependency with no gamepad r=baku
We will need followup: dom/bindings/GamepadServiceTestBinding.cpp:10:44: fatal error: mozilla/dom/GamepadServiceTest.h: No such file or directory

This was hidden by other build failures :/
Blocks: 1283313
Summary: ipc/glue/PBackground.ipdl:16: error: can't locate include file `PGamepadEventChannel.ipdl' → broken --disable-gamepad: ipc/glue/PBackground.ipdl:16: error: can't locate include file `PGamepadEventChannel.ipdl'
(In reply to Alexandre LISSY :gerard-majax from comment #9)
> We will need followup: dom/bindings/GamepadServiceTestBinding.cpp:10:44:
> fatal error: mozilla/dom/GamepadServiceTest.h: No such file or directory
> 
> This was hidden by other build failures :/

Maybe you can try my patch here, I've tested it on Mac OSX with ac_add_options --disable-gamepad.
https://bugzilla.mozilla.org/show_bug.cgi?id=1282993
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
(In reply to Carsten Book [:Tomcat] from comment #13)
> https://hg.mozilla.org/mozilla-central/rev/bcd10b16cb33

Sorry, we should backout this and just let bug 1282993 make it to the tree
Flags: needinfo?(cbook)
(In reply to Alexandre LISSY :gerard-majax from comment #14)
> (In reply to Carsten Book [:Tomcat] from comment #13)
> > https://hg.mozilla.org/mozilla-central/rev/bcd10b16cb33
> 
> Sorry, we should backout this and just let bug 1282993 make it to the tree

backout done in https://hg.mozilla.org/mozilla-central/rev/82e1f1b9c055
Flags: needinfo?(cbook)
You need to log in before you can comment on or make changes to this bug.