1283135 - broken --disable-gamepad: ipc/glue/PBackground.ipdl:16: error: can't locate include file `PGamepadEventChannel.ipdl'

Status: RESOLVED DUPLICATE of bug 1282993

(Firefox OS Graveyard :: General, defect)

Description

[:gerard-majax]

fallout from bug 1221730

Comment 1

[:gerard-majax]

Reproduced on gonk or when using --disable-gamepad

Comment 2

[:gerard-majax]

maybe another usecase for bug 1274518 ?

Comment 3

[:gerard-majax]

Attachment: Bug 1283135 - Fix gamepad IPDL dependency with no gamepad

Review commit: https://reviewboard.mozilla.org/r/61298/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61298/

Comment 4

[Andrea Marchesini [:baku]]

Comment on attachment 8766368 [details]
Bug 1283135 - Fix gamepad IPDL dependency with no gamepad

https://reviewboard.mozilla.org/r/61298/#review58168

Instead doing this, what about if you remove: "if CONFIG['MOZ_GAMEPAD']:" from dom/moz.build and change how dom/gamepad/moz.build works?

Comment 5

[:gerard-majax]

Comment on attachment 8766368 [details]
Bug 1283135 - Fix gamepad IPDL dependency with no gamepad

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61298/diff/1-2/

Comment 6

[Andrea Marchesini [:baku]]

Comment on attachment 8766368 [details]
Bug 1283135 - Fix gamepad IPDL dependency with no gamepad

https://reviewboard.mozilla.org/r/61298/#review58184

::: dom/gamepad/moz.build:76
(Diff revision 2)
>  ]
>  
>  CFLAGS += CONFIG['GLIB_CFLAGS']
>  CFLAGS += CONFIG['MOZ_DBUS_GLIB_CFLAGS']
>  CXXFLAGS += CONFIG['GLIB_CFLAGS']
>  CXXFLAGS += CONFIG['MOZ_DBUS_GLIB_CFLAGS']

move also from line 66 to 76 into the if()

Comment 7

[:gerard-majax]

Comment on attachment 8766368 [details]
Bug 1283135 - Fix gamepad IPDL dependency with no gamepad

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61298/diff/2-3/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bcd10b16cb33
Fix gamepad IPDL dependency with no gamepad r=baku

Comment 9

[:gerard-majax]

We will need followup: dom/bindings/GamepadServiceTestBinding.cpp:10:44: fatal error: mozilla/dom/GamepadServiceTest.h: No such file or directory

This was hidden by other build failures :/

Comment 11

[Michael Leu[:Lenzak](UTC+8)]

(In reply to Alexandre LISSY :gerard-majax from comment #9)
> We will need followup: dom/bindings/GamepadServiceTestBinding.cpp:10:44:
> fatal error: mozilla/dom/GamepadServiceTest.h: No such file or directory
> 
> This was hidden by other build failures :/

Maybe you can try my patch here, I've tested it on Mac OSX with ac_add_options --disable-gamepad.
https://bugzilla.mozilla.org/show_bug.cgi?id=1282993

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bcd10b16cb33

Comment 14

[:gerard-majax]

(In reply to Carsten Book [:Tomcat] from comment #13)
> https://hg.mozilla.org/mozilla-central/rev/bcd10b16cb33

Sorry, we should backout this and just let bug 1282993 make it to the tree

Comment 15

[Carsten Book [:Tomcat]]

(In reply to Alexandre LISSY :gerard-majax from comment #14)
> (In reply to Carsten Book [:Tomcat] from comment #13)
> > https://hg.mozilla.org/mozilla-central/rev/bcd10b16cb33
> 
> Sorry, we should backout this and just let bug 1282993 make it to the tree

backout done in https://hg.mozilla.org/mozilla-central/rev/82e1f1b9c055