1283409 - Incorrect functionality when entering passcode and changing device orientation on iPhone 6 Plus

Status: VERIFIED FIXED

(Firefox for iOS :: Login Management, defect, P1)

Description

[Simon Basca [:SimonB]]

Build: 5.0b14
Device: IPhone 6 Plus (9.1)

Steps to reproduce:
1. Turn passcode functionality on and enter a passcode
2. Tap Logins section 
3. Change device orientation to landscape 
4. Type the passcode

Actual results:
- The keyboard buttons will not be functional when changing the device orientation to landscape. When changing the device orientation back to portrait, the keyboard will not be displayed.

Expected results:
- The keyboard should have proper functionality and should be correctly displayed while changing the device orientation.

Note:
- This issue occurs only on iPhone 6 Plus when accessing logins with passcode functionality on.

Comment 1

[Simon Basca [:SimonB]]

Please see similar issue reported here https://bugzilla.mozilla.org/show_bug.cgi?id=1272299 and fixed here https://bugzilla.mozilla.org/show_bug.cgi?id=1270087

Comment 2

[Farhan Patel [:farhan]]

This should be fixed by the bug here https://bugzilla.mozilla.org/show_bug.cgi?id=1304691
I'll double check it once the bug lands in master.

Comment 3

[Catalin Suciu [:csuciu]]

Tested on master 4779a27b5 which contains the fix for bug #1304691 and this issue is still reproducible

Comment 4

[Farhan Patel [:farhan]]

Attachment: Pull Request

Comment 5

[Farhan Patel [:farhan]]

master https://github.com/mozilla-mobile/firefox-ios/commit/5a51f65ad92f5410a4cada6d6e8f3b3bee9b45b0

Comment 6

[Simon Basca [:SimonB]]

Verifying as fix on master 0e03028ac.