We allow a configuration string to be passed to C_Initialize. But there is no way to add a module with a string in one call. The current SECMOD_AddNewModule does not take a parameter string. The fix is to create a new SECMOD_AddNewModuleEx that takes the module parameters. I have also added an argument for the NSS parameters. Both can be NULL. The SEMCOD_AddNewModule should just call SECMOD_AddNewModuleEx and pass NULL for those two modparms and nssparms arguments, which is equivalent to what's happening today.
Assignee: wtc → jpierre
Priority: -- → P2
Target Milestone: --- → 3.4
Created attachment 71967 [details] [diff] [review] proposed patch to implement SECMOD_AddNewModuleEx Bob, please review this one.
Comment on attachment 71967 [details] [diff] [review] proposed patch to implement SECMOD_AddNewModuleEx Looks good, the only nit is wherever possible we try to add functions in alphabetic order in nss.def. It's clear the SECMOD_DeleteModule is out of order as well. We should probably fix this before we ship NSS 3.4 or we will have to freeze the wrong order in place. bob
Attachment #71967 - Flags: review+
Bob, Since the sorting issue in nss.def isn't specific to this bug and pre-existing, should I check this in as-is and open a separate bug for the sorting ?
It's a small enough deal I would suggest just fixing it when you check in this bug. bob
Checked in. Checking in pk11util.c; /cvsroot/mozilla/security/nss/lib/pk11wrap/pk11util.c,v <-- pk11util.c new revision: 1.25; previous revision: 1.24 done Checking in secmod.h; /cvsroot/mozilla/security/nss/lib/pk11wrap/secmod.h,v <-- secmod.h new revision: 1.8; previous revision: 1.7 done Checking in nss.def; /cvsroot/mozilla/security/nss/lib/nss/nss.def,v <-- nss.def new revision: 1.56; previous revision: 1.55 done
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.