128360 - Go button in Search doesn't work with enter

Status: VERIFIED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[Terri Preston]

Steps to reproduce:
1. From the help drop down menu select Help and Support Center
2. Click on the Search tab
3. Enter some text in the text field (perhaps bookmarks)
4. Press Enter


Expected results: that the help ceter would be searched and show my matches

Actual results:Nothing happens, you have to click with the mouse to begin the search

Comment 1

[Terri Preston]

oops, win XP build 2002022808, mac OS X build 2002022808 and linux build
2002022809, changing os to all

Comment 2

[Ian Oeschger (gone)]

Attachment: adding enter key to find textbox

Another patch from the amazing peter wilson.

Comment 3

[Blake Ross]

While you're here, please remove the Find text and make the button's label Search.

Comment 4

[Ian Oeschger (gone)]

Blake
Does this mean you are looking at the help stuff?? Because the update you want
here is sitting in 107188, along with a tooltip update. And I *really* need to
get some reviews.

The stuff I am working on is patched into: 
107188  toolbar tooltip128360  do <enter> for search textbox
128098  expand index display
129061  add search db file, remove index from search datasources
129540  help buttons needed in UI 
In addition to these, I need to write a bug and post a patch for doing some
better regular expression stuff for the search, which I have with me here. Could
we maybe pour over these or something? What happened to the ol' Blake and Ian
team we had for 6.0? We used to be such buddies... :(

Comment 5

[Ian Oeschger (gone)]

*** Bug 128477 has been marked as a duplicate of this bug. ***

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 72686 [details] [diff] [review]
adding enter key to find textbox

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 7

[Ian Oeschger (gone)]

Marking FIXED.

Comment 8

[Terri Preston]

Works on win Xp build 2002040403, Linux build 2002040409, does not work on Mac
OSX build 2002040411, reopening to that OS

Comment 9

[rudman]

Resetting milestone and impact.

Comment 10

[Blake Ross]

Attachment: patch for mac

Comment 11

[Blake Ross]

-> me

Comment 12

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 81431 [details] [diff] [review]
patch for mac

sr=[e-mail]

Comment 13

[Brian Ryner (not reading)]

Comment on attachment 81431 [details] [diff] [review]
patch for mac

r=bryner

Comment 14

[Blake Ross]

fixed on trunk.

Comment 15

[Terri Preston]

Verified fixed Mac OS X trunk build 2002050103

Comment 16

[Jaime Rodriguez, Jr.]

Let's review this one in the RTM timeframe. adt1.0.0- [adt2 RTM]