Closed
Bug 1283645
Opened 9 years ago
Closed 9 years ago
JS breakage in Safari, older Firefox versions (FF < 44): Unexpected use of reserved word 'let'
Categories
(Webtools Graveyard :: DXR, defect)
Webtools Graveyard
DXR
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: erik, Assigned: erik)
References
Details
(Whiteboard: js)
Doing a search in Safari doesn't work and throws JS errors:
[Error] SyntaxError: Unexpected keyword 'const'. Const declarations are not supported in strict mode.
(anonymous function) (dxr.11309fe2.js:240)
[Error] SyntaxError: Unexpected use of reserved word 'let' in strict mode
(anonymous function) (context_menu.6820aff2.js:33)
this is broken in a lot of browsers, not just Safari: http://caniuse.com/#search=let
Summary: JS breakage in Safari → JS breakage in Safari, older Firefox versions (FF < 44): Unexpected use of reserved word 'let'
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → erik
Assignee | ||
Comment 2•9 years ago
|
||
Comment 3•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/dxr
https://github.com/mozilla/dxr/commit/4f83ae7427a70bb80ffe001c5b8d81573e7ac899
Remove ES6-isms. Fixes bug 1283645.
The latest Safari (9.1.1) and pre-44 versions of FF can't handle them, so search was broken.
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 4•9 years ago
|
||
Highlighting lines of code in Safari now broken. JS error unexpected const in non-strict mode.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 6•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/dxr
https://github.com/mozilla/dxr/commit/545abac37baab884f43017fbe3c1b18ad24a228a
Use var instead of const, fixes bug 1283645. (#609)
Updated•9 years ago
|
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•