1283664 - Add minimum to Apache2::SizeLimit to ensure better performance

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[Dylan Hardison [:dylan] (he/him)]

The current default (250_000) is way too low. dkl mentioned 600_000 as a bare minimum so we'll go with that.

Comment 1

[David Lawrence [:dkl]]

250_000 is what is set for a new installation and should be raised based on the administrators judgement. Are you saying we should raise the default to 600_000 out of the box?

dkl

Comment 2

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1283664_1.patch

Comment 3

[David Lawrence [:dkl]]

Comment on attachment 8767221 [details] [diff] [review]
1283664_1.patch

Review of attachment 8767221 [details] [diff] [review]:
-----------------------------------------------------------------

::: mod_perl.pl
@@ +61,5 @@
>  # This means that every httpd child will die after processing a request if it
>  # is taking up more than $apache_size_limit of RAM all by itself, not counting RAM it is
>  # sharing with the other httpd processes.
> +my $limit = Bugzilla->localconfig->{apache_size_limit};
> +$limit = 600_000 if $limit < 600_000;

I feel the admin should be able to set this value manually to any value they choose. This would override that always. I think it is good enough that we just set a good default. You can explain that lower values will hurt performance in template/en/default/setup/strings.txt.pl

Comment 4

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1283664_2.patch

just the minimum

Comment 5

[David Lawrence [:dkl]]

Comment on attachment 8768547 [details] [diff] [review]
1283664_2.patch

Review of attachment 8768547 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

Comment 6

[Dylan Hardison [:dylan] (he/him)]

To [e-mail]:mozilla-bteam/bmo.git
   2ba767c..bbe5dcd  master -> master