Closed
Bug 1283664
Opened 8 years ago
Closed 8 years ago
Add minimum to Apache2::SizeLimit to ensure better performance
Categories
(bugzilla.mozilla.org :: General, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dylan, Assigned: dylan)
References
Details
Attachments
(1 file, 1 obsolete file)
432 bytes,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
The current default (250_000) is way too low. dkl mentioned 600_000 as a bare minimum so we'll go with that.
Comment 1•8 years ago
|
||
250_000 is what is set for a new installation and should be raised based on the administrators judgement. Are you saying we should raise the default to 600_000 out of the box? dkl
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8767221 -
Flags: review?(dkl)
Comment 3•8 years ago
|
||
Comment on attachment 8767221 [details] [diff] [review] 1283664_1.patch Review of attachment 8767221 [details] [diff] [review]: ----------------------------------------------------------------- ::: mod_perl.pl @@ +61,5 @@ > # This means that every httpd child will die after processing a request if it > # is taking up more than $apache_size_limit of RAM all by itself, not counting RAM it is > # sharing with the other httpd processes. > +my $limit = Bugzilla->localconfig->{apache_size_limit}; > +$limit = 600_000 if $limit < 600_000; I feel the admin should be able to set this value manually to any value they choose. This would override that always. I think it is good enough that we just set a good default. You can explain that lower values will hurt performance in template/en/default/setup/strings.txt.pl
Attachment #8767221 -
Flags: review?(dkl) → review-
Assignee | ||
Comment 4•8 years ago
|
||
just the minimum
Attachment #8767221 -
Attachment is obsolete: true
Attachment #8768547 -
Flags: review?(dkl)
Comment 5•8 years ago
|
||
Comment on attachment 8768547 [details] [diff] [review] 1283664_2.patch Review of attachment 8768547 [details] [diff] [review]: ----------------------------------------------------------------- r=dkl
Attachment #8768547 -
Flags: review?(dkl) → review+
Assignee | ||
Comment 6•8 years ago
|
||
To git@github.com:mozilla-bteam/bmo.git 2ba767c..bbe5dcd master -> master
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•