Closed Bug 1283910 Opened 8 years ago Closed 8 years ago

"Acid Defender" WebAudio game has extra beep artifacts in Firefox 50

Categories

(Core :: Web Audio, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox47 --- unaffected
firefox48 --- unaffected
firefox49 --- unaffected
firefox50 + fixed

People

(Reporter: cpeterson, Assigned: dminor)

References

()

Details

(Keywords: regression)

Attachments

(1 file)

[Tracking Requested - why for this release]:

Dan, this is a regression in Nightly 50 from bug 1276483.

STR:
1. Load http://cappel-nord.de/webaudio/acid-defender/
2. Click the "Jam Mode" button.
3. Wait a couple seconds for the music sequencer to start playing.

RESULT:
The generated audio has extra beep artifacts at the beginning of the first two loops of the sequencer (compared to Chrome, Safari, and Firefox 49).

This Acid Defender game has caught quite a few WebAudio regressions over the years, including bug 939491, bug 956704, and bug 1172181.
Flags: needinfo?(dminor)
Thanks for the report, I'll have a look.
Assignee: nobody → dminor
Rank: 15
Flags: needinfo?(dminor)
Priority: -- → P1
Comment on attachment 8767724 [details]
Bug 1283910 - Fix initialization of WaveShaperNode output buffer in null input case;

https://reviewboard.mozilla.org/r/62138/#review59026

Could get get a test for this?
Attachment #8767724 - Flags: review?(padenot) → review+
https://reviewboard.mozilla.org/r/62138/#review59026

I've fixed up the original test case to catch this problem if it reoccurs in the future, unless by chance the unitialized buffer happens to contain all zeros.
Comment on attachment 8767724 [details]
Bug 1283910 - Fix initialization of WaveShaperNode output buffer in null input case;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62138/diff/1-2/
Status: NEW → ASSIGNED
Pushed by dminor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/30c40d0d1149
Fix initialization of WaveShaperNode output buffer in null input case; r=padenot
https://hg.mozilla.org/mozilla-central/rev/30c40d0d1149
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Tracking 50+ for this audio regression.
Version: unspecified → Trunk
QA Whiteboard: [good first verify]
Guys im not a music person, so to me it sound fine.
The output is not bad
I have reproduced this bug with Nightly 50.0a1 (2016-07-01) on Linux Mint 18, 64 bit!
The bug's fix is now verified on latest Nightly 52.0a1.

Nightly 52.0a1:

Build ID 	20161017030209
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: