1283936 - Remove Alerts preferences and UI for OS X

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Javi Rueda :javirid]

Bug 1106815 will alert always user when new messages arrive. Preference mail.biff.show_alert is now deprecated on OS X. Preference UI should be cleaned up, directing user to set it up on the Notification Center (that is my suggestion).

STR
----

1. Open Preferences from the Thunderbird menu on OS X
2. Open General tab
3. User can enable or disable if he wants Thunderbird to show an alert when a new message arrives.
4. Thunderbird will always (when related bug lands) show an alert.
5. That will confuse user.

Expected
--------
No checkbox for enabling or disabling it, maybe directing user to the Notification Center. The Notification Center is not a intuitive place where to look when user has problems about alerts, so it would be great if we suggest that instead of just removing the UI.

Comment 1

[Javi Rueda :javirid]

Attachment: insta.tiff

Removed the checkbox and showing a label to direct user to the System Settings.

Comment 2

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 8767380 [details]
insta.tiff

Seems good.  It would be nice if we could also add a button that opens up the appropriate preference pane in macOS…

Comment 3

[Javi Rueda :javirid]

Yeah, Blake. I of it. However, as far as I have been able to see, there is no an official API to do that and Apple is adding restrictions on which apps could get to it. Some people are trying it by opening an URL but Apple dislikes. Maybe because they don't want any user to be surprised if an app opens the System Settings without being asked to.

I haven't see any other app which includes such a button, neither the ones from Apple.

Comment 4

[Javi Rueda :javirid]

Attachment: Patch

Removes the UI for setting the mailnews.biff.show_alerts preference and shows a label instructing the user to open System Settings instead.

I think it is uneeded to remove the preference itself until /suite do it, as now it would need two ifndef's: one for Thunderbird and the nested one for OS X. Anyway I am not even certain that nested ifdefs are possible.

Could you take a look at this patch, Magnus? Thank you.

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 8767925 [details] [diff] [review]
Patch

Review of attachment 8767925 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thx Javier! r=mkmelin

Comment 6

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/30ecaa439ba607c359584f12f7b051ffc86426d0
Bug 1283936 - Remove Alerts preferences and UI for OS X. ui-r=bwinton r=mkmelin