1284264 - Thunderbird release automation shouldn't touch mozilla-* versions on default

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect)

Description

[Rail Aliiev [:rail]]

see https://hg.mozilla.org/releases/mozilla-esr45/rev/188615976db5, https://hg.mozilla.org/releases/mozilla-esr45/rev/0745c581ec5f

I'm going to fix the current version and make sure it doesn't happen again.

Comment 1

[Rail Aliiev [:rail]]

Attachment: Bug 1284264 - Thunderbird release automation shouldn't touch mozilla-* versions on default

Review commit: https://reviewboard.mozilla.org/r/62118/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62118/

Comment 2

[Rail Aliiev [:rail]]

Pushed fix: https://hg.mozilla.org/releases/mozilla-esr45/rev/d5b5d3e88b56

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

(In reply to Rail Aliiev [:rail] from comment #2)
> Pushed fix: https://hg.mozilla.org/releases/mozilla-esr45/rev/d5b5d3e88b56

Are you sure that's right ? I was expecting to see the undoing of these
 https://hg.mozilla.org/releases/mozilla-esr45/rev/188615976db5
 https://hg.mozilla.org/releases/mozilla-esr45/rev/188615976db5

aka, we should have an esr suffix in the version.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Should said
 https://hg.mozilla.org/releases/mozilla-esr45/rev/188615976db5
 https://hg.mozilla.org/releases/mozilla-esr45/rev/0745c581ec5f

Comment 5

[Rail Aliiev [:rail]]

Yes, esr's app version should not contain "esr", see http://hg.mozilla.org/build/buildbot-configs/file/tip/mozilla/release-firefox-mozilla-esr45.py#l25

See also bug 1276528.

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8767691 [details]
Bug 1284264 - Thunderbird release automation shouldn't touch mozilla-* versions on default

https://reviewboard.mozilla.org/r/62118/#review58962

Looks good to me. BTW, our hg out and hg push code doesn't use '-r .', so we're in for fun if we start using a unified gecko repo.

Comment 7

[Rail Aliiev [:rail]]

(In reply to Nick Thomas [:nthomas] from comment #6)
> Looks good to me. BTW, our hg out and hg push code doesn't use '-r .', so
> we're in for fun if we start using a unified gecko repo.

Lalalallala :D

Jokes aside, yes, we should revisit a lot of things when we start using a unified gecko repo.

Comment 8

[Rail Aliiev [:rail]]

Comment on attachment 8767691 [details]
Bug 1284264 - Thunderbird release automation shouldn't touch mozilla-* versions on default

https://hg.mozilla.org/build/tools/rev/0a9b2d8b7efb

Comment 10

[Rail Aliiev [:rail]]

Assuming this is done