128437 - new email preferences appear to be off on "edit email preferences" page

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

When a user goes to the "edit email preferences" page after the Bugzilla
installation has added a new preference, the new preferences appear to be turned
off, even though they are actually turned on (and the user has been receiving
the applicable email since the new preference was added).  See bug 128422 for
further explanation of why this happens.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: fixes bug

This patch relies on the fix for bug 128422.

Comment 2

[Jacob Steenhagen]

Comment on attachment 72036 [details] [diff] [review]
patch v1: fixes bug

>Index: userprefs.cgi
>+    # the second by reason, and the value being 1 or 0 for (on or off).

Nit: this comment isn't gramatically correct.... either there should be now
()'s or the word "for" should be inside the ()'s.  But that's really minor and
just comment, no reason to withhold review :)

r=jake

Comment 3

[Dave Miller [:justdave]]

Comment on attachment 72036 [details] [diff] [review]
patch v1: fixes bug

r= justdave

passes tests, all my prefs show up how I expect.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Checking in userprefs.cgi;
/cvsroot/mozilla/webtools/bugzilla/userprefs.cgi,v  <--  userprefs.cgi
new revision: 1.29; previous revision: 1.28
done

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Patch checked in.  Resolving fixed.