Closed Bug 128437 Opened 21 years ago Closed 21 years ago

new email preferences appear to be off on "edit email preferences" page

Categories

(Bugzilla :: User Interface, defect)

2.15
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 2.16

People

(Reporter: myk, Assigned: myk)

References

Details

Attachments

(1 file)

When a user goes to the "edit email preferences" page after the Bugzilla
installation has added a new preference, the new preferences appear to be turned
off, even though they are actually turned on (and the user has been receiving
the applicable email since the new preference was added).  See bug 128422 for
further explanation of why this happens.
Status: NEW → ASSIGNED
This patch relies on the fix for bug 128422.
Depends on: 128422
Comment on attachment 72036 [details] [diff] [review]
patch v1: fixes bug

>Index: userprefs.cgi
>+    # the second by reason, and the value being 1 or 0 for (on or off).

Nit: this comment isn't gramatically correct.... either there should be now
()'s or the word "for" should be inside the ()'s.  But that's really minor and
just comment, no reason to withhold review :)

r=jake
Attachment #72036 - Flags: review+
Comment on attachment 72036 [details] [diff] [review]
patch v1: fixes bug

r= justdave

passes tests, all my prefs show up how I expect.
Attachment #72036 - Flags: review+
Target Milestone: --- → Bugzilla 2.16
Checking in userprefs.cgi;
/cvsroot/mozilla/webtools/bugzilla/userprefs.cgi,v  <--  userprefs.cgi
new revision: 1.29; previous revision: 1.28
done
Patch checked in.  Resolving fixed.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.