Closed Bug 1284385 Opened 8 years ago Closed 8 years ago

Release history gets data for each revision of a release, which slows page load

Categories

(Release Engineering Graveyard :: Applications: Balrog (backend), defect)

Product:
Release Engineering Graveyard
Component:
Applications: Balrog (backend)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: nthomas, Assigned: njirap, Mentored)

References

(
URL
)

Details

The example URL returns about 10MB of data, including a copy of the data for every revision covered (admittedly gzip'd). But we make extra requests if the user clicks on the Data or Diff buttons, so it seems to me this must be unused, and I'd rather the page loaded fast.
To clarify a litte, visiting a page like 
 https://aus4-admin.mozilla.org/releases/Firefox-mozilla-central-nightly-latest
makes a request like
 https://aus4-admin.mozilla.org/api/releases/Firefox-mozilla-central-nightly-latest/revisions?limit=100

The latter is ~1MB on the wire, ~9MB decompressed; takes about 6s in total, 2s of which is the server generation. And Firefox freezes up a bit while it processes all the JSON.
Summary: Release revisions returns data for each revision of a release, slow page load → Release history gets data for each revision of a release, which slows page load
I think this is going to get fixed as part of https://github.com/mozilla/balrog-ui/pull/27/files (bug 1163160). You can give it a try if you update your UI repo to dab0d84d2471a6988f91718f0e8881e5099ca1a1 (where it was briefly landed, before discovering issues that warranted a backout).
From what I can see it's going to limit the API request to the current page, so that'll help but seems like a workaround. Is there a use case for returning the blob data for each revision ?
(In reply to Nick Thomas [:nthomas] from comment #3)
> From what I can see it's going to limit the API request to the current page,
> so that'll help but seems like a workaround. Is there a use case for
> returning the blob data for each revision ?

Oh, I see now. That's a really great point - we really should not be returning the blob data when rendering the list of changes. I don't think it hurts to have bug 1163160 as well as this though?

Adding myself as mentor here to get it to show up in bugs'a'hoy and other places. Feel free to add yourself there if you want though!
Mentor: bhearsum
Assignee: nobody → njirap
Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/cbb9e8158a636569c9ddf0d69ff6552948aeb84d
bug 1284385: Release history gets data for each revision of a release, which slows page load. r=bhearsum
Thanks for fixing this Njira!
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: Release Engineering → Release Engineering Graveyard
You need to log in before you can comment on or make changes to this bug.