1284463 - The new device-list label in RDM is not properly aligned horizontally

Status: NEW

(DevTools :: Responsive Design Mode, defect, P3)

Description

[Mihai Boldan, Desktop QA [:mboldan]]

Attachment: horizonatlly aligned.png

[Affected versions]:
- Firefox 50.0a1 (2016-07-04)

[Affected platforms]:
- Windows 10 x64, Mac OS X 10.11.1, Ubuntu 14.04 x86

[Steps to reproduce]:
1. Launch Firefox.
2. From about:config, enable the devtools.responsive.html.enabled pref.
3. Enable RDM and observe the position of the dropdown button for the devices list.

[Expected result]:
- The button is correctly positioned.

[Actual result]:
- The button is wrongly positioned horizontally.

[Regression range]:
Last good revision: c3f5e6079284a7b7053c41f05d0fe06ff031db03
First bad revision: 943ca7ad1ea35e01a6ba6bfa0a4f3896f1150e15
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c3f5e6079284a7b7053c41f05d0fe06ff031db03&tochange=943ca7ad1ea35e01a6ba6bfa0a4f3896f1150e15

[Additional notes]:
- While searching for the regression range, I noticed that the position of the button was modified a few times. The found regression range is for the first time when the button was moved, and on the newer builds, the distance between the button and the string is even larger. (see the attached screenshot)

Comment 1

[Andrew Overholt [:overholt]]

Elsewhere I was told RDM isn't on by default so we're not going to hold 50 for this. Ritu, how should we note that so it's not in our queries?

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Andrew Overholt [:overholt] from comment #1)
> Elsewhere I was told RDM isn't on by default so we're not going to hold 50
> for this. Ritu, how should we note that so it's not in our queries?

I am also curious what the best way to mark bug fields for a currently off by default feature is.  Should we not use the "regression" keyword (even though regressions can exist for people testing with the feature on)?  Should we not set the status-firefox* tracking flags?

Comment 3

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

(In reply to Andrew Overholt [:overholt] from comment #1)
> Elsewhere I was told RDM isn't on by default so we're not going to hold 50
> for this. Ritu, how should we note that so it's not in our queries?

Hi Andrew, Ryan, in this case, setting status-firefox* tracking field to disabled (since it is off by default) would remove it from the Regression dashboard. However, even setting status-firefox* field to "wontfix" will also remove it from the regression dashboard. 

So, for this specific bug, we are good. I am changing it to disabled to be more accurate.

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Bug in disabled feature under development, removing regression keyword.