Closed Bug 1284475 Opened 8 years ago Closed 7 years ago

migrate ToolTool blueprint to new codebase of relengapi

Categories

(Release Engineering :: General, defect)

Product:
Release Engineering
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox57 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: garbas, Assigned: garbas)

References

Details

Attachments

(1 file, 2 obsolete files)

Bug 1284475 - migrate ToolTool blueprint to new codebase of relengapi
59 bytes, text/x-review-board-request
KWierso
: review+
Details 
      No description provided.
Blocks: 1250859
Component: Tools → General
Assignee: nobody → rgarbas
Attached patch tooltool_new_url.patch (obsolete) — — Splinter Review 
:jlund: Once tooltool is pushed to production (later today), can you help me try this on jamon branch?
Attachment #8879809 - Flags: review?(jlund)
(In reply to Rok Garbas [:garbas] from comment #1)
> Created attachment 8879809 [details] [diff] [review]
> tooltool_new_url.patch
> 
> :jlund: Once tooltool is pushed to production (later today), can you help me
> try this on jamon branch?

sure! I will try this later tonight. Anything I should be aware about?
(In reply to Jordan Lund (:jlund) from comment #2)
> (In reply to Rok Garbas [:garbas] from comment #1)
> > Created attachment 8879809 [details] [diff] [review]
> > tooltool_new_url.patch
> > 
> > :jlund: Once tooltool is pushed to production (later today), can you help me
> > try this on jamon branch?
> 
> sure! I will try this later tonight. Anything I should be aware about?

actually given the buildbot macos switchover to x-compile on taskcluster tonight (11pm pt), it is probably better to test this out after we have nightlies in case we hit infra issues.

Rok, could we try this out tomorrow morning pacific time? We are scheduled to meet anyway so that might work well with timing.
Comment on attachment 8879809 [details] [diff] [review]
tooltool_new_url.patch

Review of attachment 8879809 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/mach_commands.py
@@ +1786,5 @@
>                      record.fetch_with(cache)
> +                except (requests.exceptions.HTTPError,
> +                        requests.exceptions.ConnectionError) as e:
> +
> +                    if isinstance(e, requests.exceptions.ConnectionError)

was this an exception that wasn't being retried before?
Attachment #8879809 - Flags: review?(jlund) → review+
In addition to in-tree, we have a number of places old relengapi is referenced in buildbot, puppet, and tools[0]. They seem to be mostly for custom variant builds, thunderbird, and some release jobs so I'm not so concerned at this point.

I'm also seeing a whole bunch of references in github[1][2]. The mozilla-releng org is a buildbot repeat but there is also OpenCloudConfig. Then, under mozilla, there is quite a lot that will need to be investigated.

I don't think we need to worry about any of these for purposes of jamun. Still, worth noting as places we need to touch as we roll this out in case that list is not yet documented.

[0] https://dxr.mozilla.org/build-central/search?q=api.pub.build.mozilla.org%2Ftooltool&redirect=false
[1]https://github.com/search?q=user%3Amozilla-releng+api.pub.build.mozilla.org%2Ftooltool&type=Code&utf8=%E2%9C%93
[2] https://github.com/search?q=user%3Amozilla+api.pub.build.mozilla.org%2Ftooltool&type=Code&utf8=%E2%9C%93
(In reply to Jordan Lund (:jlund) from comment #4)
> Comment on attachment 8879809 [details] [diff] [review]
> tooltool_new_url.patch
> 
> Review of attachment 8879809 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: python/mozbuild/mozbuild/mach_commands.py
> @@ +1786,5 @@
> >                      record.fetch_with(cache)
> > +                except (requests.exceptions.HTTPError,
> > +                        requests.exceptions.ConnectionError) as e:
> > +
> > +                    if isinstance(e, requests.exceptions.ConnectionError)
> 
> was this an exception that wasn't being retried before?

oh this actually sneaked into here. that was already merged in Bug 1364695
I will prepare a clean patch.
New patch without the changes in ``python/mozbuild/mozbuild/mach_commands.py``
Attachment #8880401 - Flags: review?(jlund)
Attachment #8879809 - Attachment is obsolete: true
Attachment #8880401 - Flags: review?(jlund) → review+
Status: NEW → ASSIGNED
Depends on: 1380177
Comment on attachment 8887720 [details]
Bug 1284475 - migrate ToolTool blueprint to new codebase of relengapi

https://reviewboard.mozilla.org/r/158628/#review171076
Attachment #8887720 - Flags: review-
Comment on attachment 8887720 [details]
Bug 1284475 - migrate ToolTool blueprint to new codebase of relengapi

https://reviewboard.mozilla.org/r/158628/#review171086
Attachment #8887720 - Flags: review- → review+
Attachment #8880401 - Attachment is obsolete: true
Comment on attachment 8887720 [details]
Bug 1284475 - migrate ToolTool blueprint to new codebase of relengapi

maybe thats a better request for jlund maybe to look into this ? :)
Flags: needinfo?(rgarbas)
Attachment #8887720 - Flags: review?(cbook) → review?
tomcat: jlund is out on leave.
:tomcat: he already reviewed basically the same patch, I just learned meanwhile how to use reviewboard and send a rebased version. :)

Would next Wed (2017-08-23) be ok to merge the patch (since there is no planned release)?

What would be the best time to do it? I can adjust to be around and to monitor the new tooltool as the commit lands. And if something goes wrong we would need to just revert the commit to go to the previous state.
Flags: needinfo?(rgarbas) → needinfo?(cbook)
Attachment #8887720 - Flags: review? → review-
above patch I just rejected was obsolete was obsolete.
the up to date patch is here: https://reviewboard.mozilla.org/r/158628/#review171086
hg error in cmd: hg push -r tip ssh://hg.mozilla.org/integration/autoland: pushing to ssh://hg.mozilla.org/integration/autoland
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 19 changes to 19 files
remote: (1 changesets contain changes to protected security/nss/ directory: 8416a7707a08)
remote: ************************************************************************
remote: You do not have permissions to modify files under nsprpub/ or security/nss/
remote: 
remote: These directories are kept in sync with the canonical upstream repositories at
remote: https://hg.mozilla.org/projects/nspr and https://hg.mozilla.org/projects/nss
remote: 
remote: Please contact the NSPR/NSS maintainers at nss-dev@mozilla.org or on IRC
remote: channel #nss to request that your changes are merged, released and uplifted.
remote: ************************************************************************
remote: transaction abort!
remote: rollback completed
remote: pretxnchangegroup.f_prevent_nspr_nss_changes hook failed
abort: push failed on remote
Pushed by kwierso@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/0eebae2f0977
migrate ToolTool blueprint to new codebase of relengapi r=KWierso
https://hg.mozilla.org/mozilla-central/rev/0eebae2f0977
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Depends on: 1396937
Flags: needinfo?(cbook)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: