128449 - [FIX]Context menus can cause crash when in PrintPreview

Status: VERIFIED FIXED

(Core :: Print Preview, defect)

Description

[rods (gone)]

Comment 1

[rods (gone)]

Attachment: patch (k drive)

This creates a small ContextMenuListener object and uses it to "prevent" the
events from being processed by the DOM for the PP document.

The listener is added and removed when only PP.

Comment 2

[dcone (gone)]

Comment on attachment 72052 [details] [diff] [review]
patch (k drive)

r=dcone

Comment 3

[rods (gone)]

Comment on attachment 72052 [details] [diff] [review]
patch (k drive)

A new patch is coming that registers and prevents more than just context menu
events.

Comment 4

[rods (gone)]

Attachment: patch

Add event listeners to "prevent" ContextMenu, Key, Mouse and MouseMotion events
from being processed.

Comment 5

[rods (gone)]

*** Bug 128254 has been marked as a duplicate of this bug. ***

Comment 6

[rods (gone)]

Comment on attachment 72778 [details] [diff] [review]
patch

This bug now depends on Bug 124990. We are listening and properly canceling
(preventing) the mouse events, but the order of the ergistered listeners is
causing us problems. Bug 124990 will let us register the PP listener before the
listeners that are registered by the form controls.

Comment 7

[Marc Attinasi]

Comment on attachment 72778 [details] [diff] [review]
patch

In InstallPrintPreviewListener

You cannot assert that a 'new' wil succeed:

NS_ASSERTION(mPrt->mPPEventListeners, "Error getting nsPrintPreviewListener");

You have no control over when memory is available or not, so handle the error
case and drop the assert.

Also, I do not think you can assert that 
mPrt->mPPEventListeners->AddListeners() will always succeed. Again, handle the
error or make sure it cannot happen (and get rid of or ignore the result).

Otherwise, sr=attinasi

Comment 8

[dcone (gone)]

Comment on attachment 72778 [details] [diff] [review]
patch

Marc's changes and you have my r. r=dcone

Comment 9

[rods (gone)]

Changes have been made ready for check in.

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 72778 [details] [diff] [review]
patch

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 11

[rods (gone)]

fixed

Comment 12

[sujay]

verified in 3/25 build.

Comment 13

[rods (gone)]

If you still see the problem on Linux with Comboboxes please dup or look at Bug
133478. This checkin was the more generic case for many of the problems. The
more specific case of the combobox is covered under the new bug and is the part
of the check in that depends on joki's fix for Bug 124990