Closed Bug 1284911 Opened 5 years ago Closed 5 years ago

Enable Treeherder's ability to add TaskCluster jobs to try pushes

Categories

(Testing :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: armenzg, Assigned: martianwars)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

In bug 1254325 we added TaskCluster jobs to Treeherder's runnable API.
In this bug we will enable the feature of adding new TaskCluster jobs through Treeherder's UI.

This depends on being able to schedule actions tasks via pulse_actions (bug 1281062).
Once this has been landed, the following test cases need to be evaluated :-
1. Only a Build is scheduled
2. Only a Test is scheduled
3. Both a build and test are scheduled
4. Test depending on a running build is scheduled

We also need to follow up by further optimizing action tasks to utilize old action tasks in same push.
Depends on: 1254325
Depends on: 1286843
Comment on attachment 8771000 [details] [review]
[treeherder] martiansideofthemoon:thefinalcountdown > mozilla:master

This Pull Request should be merged once the Pulse Actions credentials have been updated. That should happen later today right @Armen?
Flags: needinfo?(armenzg)
Attachment #8771000 - Flags: review?(emorley)
Blocks: 1286894
martianwars tested these case scenarions and I verified it.

This push only requested a L64 debug test with a reftest job.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=20af57a728fb
We used that push for cases 1, 2 & 4.

For case #3 we used this push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=31ed08cd2d7d69c7f12222597124dfaea8b285f7

#1 - Only a build is scheduled

martianwars requested an Android build. You can see the aftermath in this screenshot [1]
The build started running after the action task completed.
You can see the task group for it [2]

[1] http://people.mozilla.org/~armenzg/sattap/0bd7cead.png
[2] https://tools.taskcluster.net/task-group-inspector/#FEWCgomXRMKCzZ98cP1sDw/


#2 - Only a test is scheduled

I have requested an Android debug test. Since the test depends on a build that's not running, a build has been scheduled.
Here is the task group for this [1]. A snapshot of the result can be seen in [2].
* android debug build scheduled [3]. Now complete
* android debug test scheduled [4]. Now it's complete.

[1] https://tools.taskcluster.net/task-group-inspector/#Ho0l-41aR1yBfhqgWP7bDw/
[2] http://picpaste.com/Screenshot_from_2016-07-14_21_51_21-sBKp8gvh.png
[3] https://tools.taskcluster.net/task-inspector/#HUHyR2_XQd-X745gDTYZGA/0
[4] https://tools.taskcluster.net/task-inspector/#RQ-sEUU6TAmbPDJHQFyZrA/0


#3 - Both a build and test are scheduled
We can see both test and build scheduled in the group inspector:
https://tools.taskcluster.net/task-group-inspector/#GtWiBT5jRPO79oAziMws3g/

#4 - Test depending on a running build is scheduled
In this case, only an action task is scheduled [1] since the build is still running.
From looking at the output I can see that a task has been scheduled [2]
If I open the group inspector I only see that task [3], however, in the task inspector I can see that it depends on:
* desktop test docker imager builder [4] (completed)
* Linux 64 debug job [5] (running) (now complete)
* An e10s mochitest job is now running [6]. Now it's complete.

[1] https://tools.taskcluster.net/task-inspector/#G_ICo2v9TJy5KQf1vYfFsw/0
[2] https://tools.taskcluster.net/task-inspector/#dxBXPA9qTy-DpvLjxDYydg/
[3] https://tools.taskcluster.net/task-group-inspector/#a2ybAUuES82lln9dlFMZuA/
[4] https://tools.taskcluster.net/task-inspector/#SzWsEsVwRJihXcPvY7uwjA/
[5] https://tools.taskcluster.net/task-inspector/#HprF83hvRNmYD58wOYTsAA/
[6] https://tools.taskcluster.net/task-inspector/#dxBXPA9qTy-DpvLjxDYydg/0
I'm hoping garndt or dustin can get to update the credentials either today or tomorrow.

I think we can go ahead and enable it on Treeherder since it will take a bit before we make a production push for Treeherder.
Flags: needinfo?(armenzg)
Comment on attachment 8771000 [details] [review]
[treeherder] martiansideofthemoon:thefinalcountdown > mozilla:master

Left a comment on the PR
Attachment #8771000 - Flags: review?(emorley)
Comment on attachment 8771000 [details] [review]
[treeherder] martiansideofthemoon:thefinalcountdown > mozilla:master

I hope it's better now
Attachment #8771000 - Flags: review?(emorley)
What did we decide last week on IRC?

Can we enable it this week?
Attachment #8771000 - Flags: review?(emorley) → review+
Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/9a30c530ee1a2d49ad91bb12fd9334b40ccd9ef5
Bug 1284911 - Enable Treeherder's ability to add TaskCluster jobs to try pushes.

https://github.com/mozilla/treeherder/commit/915c962eb3d010e290bf3369e7ad43e95c96f81b
Bug 1284911 - Adding check to avoid confusion with old action tasks.

Action Tasks are tasks which will be generated when the "Add New Jobs" button is pressed, and TaskCluster jobs are scheduled.
Action Tasks will contain all the relevant logs. An orange Action Task would mean "Add New Jobs" has failed for Action Tasks.

Action Tasks are placed under the gecko-decision group. This check improves the filter which earlier assumed that there was just a single job under gecko-decision.
Hence when we've scheduled an Action Task on that push in the past, this filter will be necessary to avoid internal server errors.
Seems to work well!
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b649a1cda39222950c94ab6c3fe4c6d61a3ff149
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Blocks: 1288028
Blocks: 1286813
You need to log in before you can comment on or make changes to this bug.