Intermittent testing/marionette/client/marionette_driver/marionette.py:1050:100 | line too long (100 > 99 characters) (E501)

RESOLVED FIXED

Status

Testing
Marionette
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Treeherder Bug Filer, Assigned: whimboo)

Tracking

({intermittent-failure})

Version 3
intermittent-failure
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Comment 1

2 years ago
This has been caused by my patch on bug 1282570. I will get it fixed.
Assignee: nobody → hskupin
Blocks: 1282570
Status: NEW → ASSIGNED
(Assignee)

Comment 2

2 years ago
Created attachment 8768527 [details]
Bug 1284982 - Fix flake8 warning for a too long comment.

Review commit: https://reviewboard.mozilla.org/r/62718/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62718/
Attachment #8768527 - Flags: review?(mjzffr)
(Assignee)

Comment 3

2 years ago
https://reviewboard.mozilla.org/r/62718/#review59450

::: testing/marionette/client/marionette_driver/marionette.py:1046
(Diff revision 1)
>          self.start_session(session_id=self.session_id)
>          self._reset_timeouts()
>  
>          if in_app:
> -            # In some cases Firefox restarts itself by spawning into a new process group. As long as
> -            # mozrprocess cannot track that (bug 1176758) we assist by checking the new process id.
> +            # In some cases Firefox restarts itself by spawning into a new process group.
> +            # As long as mozprocess cannot track that behavior (bug 1284864) we assist by

A new bug got actually filed after we landed this patch. So I also updated its number.
Comment on attachment 8768527 [details]
Bug 1284982 - Fix flake8 warning for a too long comment.

https://reviewboard.mozilla.org/r/62718/#review59466
Attachment #8768527 - Flags: review?(mjzffr) → review+
(Assignee)

Comment 5

2 years ago
This patch is not necessary anymore given that bug 1282570 got backed out due to failures for OSX debug builds.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED

Comment 6

2 years ago
16 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 12
* mozilla-inbound: 2
* mozilla-central: 1
* fx-team: 1

Platform breakdown:
* lint: 16

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1284982&startday=2016-07-04&endday=2016-07-10&tree=all
You need to log in before you can comment on or make changes to this bug.