1284982 - Intermittent testing/marionette/client/marionette_driver/marionette.py:1050:100 | line too long (100 > 99 characters) (E501)

Status: RESOLVED FIXED

(Testing :: Marionette Client and Harness, defect)

Description

[Treeherder Bug Filer]

Filed by: Wnf6VPw98Cn_qQasqiL7WyBmHjg

https://treeherder.mozilla.org/logviewer.html#?job_id=312018&repo=autoland

https://queue.taskcluster.net/v1/task/TSM3jSE2TTGlUgOAlEY3Gg/runs/0/artifacts/public%2Flogs%2Flive_backing.log

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This has been caused by my patch on bug 1282570. I will get it fixed.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1284982 - Fix flake8 warning for a too long comment.

Review commit: https://reviewboard.mozilla.org/r/62718/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62718/

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

https://reviewboard.mozilla.org/r/62718/#review59450

::: testing/marionette/client/marionette_driver/marionette.py:1046
(Diff revision 1)
>          self.start_session(session_id=self.session_id)
>          self._reset_timeouts()
>  
>          if in_app:
> -            # In some cases Firefox restarts itself by spawning into a new process group. As long as
> -            # mozrprocess cannot track that (bug 1176758) we assist by checking the new process id.
> +            # In some cases Firefox restarts itself by spawning into a new process group.
> +            # As long as mozprocess cannot track that behavior (bug 1284864) we assist by

A new bug got actually filed after we landed this patch. So I also updated its number.

Comment 4

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8768527 [details]
Bug 1284982 - Fix flake8 warning for a too long comment.

https://reviewboard.mozilla.org/r/62718/#review59466

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This patch is not necessary anymore given that bug 1282570 got backed out due to failures for OSX debug builds.

Comment 6

[Intermittent Failures Robot]

16 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 12
* mozilla-inbound: 2
* mozilla-central: 1
* fx-team: 1

Platform breakdown:
* lint: 16

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1284982&startday=2016-07-04&endday=2016-07-10&tree=all

Comment 7

[BMO Automation]

Moving bug to Testing::Marionette Client and Harness component per bug 1815831.