1285117 - Pass WebGL2 conformance conformance/extensions/webgl-compressed-texture-atc.html

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Ethan Lin[:ethlin]]

FAIL supportedFormats.length should be 10. Was 0.

Comment 1

[Ethan Lin[:ethlin]]

Attachment: generate compressed format array

For webgl2, put the compressed format into the mCompressedTextureFormats.

Comment 2

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1285117 - Reintroduce WebGL2 compressed formats. -

Review commit: https://reviewboard.mozilla.org/r/63320/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63320/

Comment 3

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8768658 [details] [diff] [review]
generate compressed format array

Review of attachment 8768658 [details] [diff] [review]:
-----------------------------------------------------------------

We also need to reintroduce the formats in WebGLFormats.

Comment 4

[Kelsey Gilbert [:jgilbert]]

This also fixes:
    conformance2/textures/misc/compressed-tex-image.html (Passed: 16/28 Failed: 12/28 in 738.0 ms)
    conformance/extensions/webgl-compressed-texture-pvrtc.html (Passed: 4/5 Failed: 1/5 in 382.0 ms)
    conformance/extensions/webgl-compressed-texture-s3tc.html (Passed: 734/738 Failed: 4/738 in 3081.0 ms)

Comment 5

[Kelsey Gilbert [:jgilbert]]

Green try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=02ce2669c054

Comment 6

[Kelsey Gilbert [:jgilbert]]

(In reply to Jeff Gilbert [:jgilbert] from comment #4)
> This also fixes:
>     conformance2/textures/misc/compressed-tex-image.html (Passed: 16/28
> Failed: 12/28 in 738.0 ms)
>     conformance/extensions/webgl-compressed-texture-pvrtc.html (Passed: 4/5
> Failed: 1/5 in 382.0 ms)
>     conformance/extensions/webgl-compressed-texture-s3tc.html (Passed:
> 734/738 Failed: 4/738 in 3081.0 ms)

Also:
conformance2/textures/misc/tex-storage-compressed-formats.html

Comment 7

[Ethan Lin[:ethlin]]

Comment on attachment 8769379 [details]
Bug 1285117 - Reintroduce WebGL2 compressed formats. -

https://reviewboard.mozilla.org/r/63320/#review60212

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b957e4b64c2b
Reintroduce WebGL2 compressed formats. - r=ethlin

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a9c859747e5
Just return 0 on assert path. CLOSED TREE

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b957e4b64c2b
https://hg.mozilla.org/mozilla-central/rev/5a9c859747e5