1285170 - [pine => m-c] Kill app:// protocol

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Comment 1

[:gerard-majax]

I will only handle app:// protocol removal, not the switch of gaia to chrome://

Comment 2

[:gerard-majax]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8365b217705b

Comment 3

[:gerard-majax]

Attachment: Bug 1285170 - Remove app:// protocol

Review commit: https://reviewboard.mozilla.org/r/62802/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62802/

Comment 4

[:gerard-majax]

Comment on attachment 8768686 [details]
Bug 1285170 - Remove app:// protocol

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62802/diff/1-2/

Comment 5

[:gerard-majax]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=60e76873e2bf

Comment 6

[:gerard-majax]

Comment on attachment 8768686 [details]
Bug 1285170 - Remove app:// protocol

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62802/diff/2-3/

Comment 7

[:gerard-majax]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d63147f8e4f

Comment 8

[:gerard-majax]

Comment on attachment 8768686 [details]
Bug 1285170 - Remove app:// protocol

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62802/diff/3-4/

Comment 9

[:gerard-majax]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f2787d439cb7

Comment 10

[:gerard-majax]

Comment on attachment 8768686 [details]
Bug 1285170 - Remove app:// protocol

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62802/diff/4-5/

Comment 11

[Valentin Gosu [:valentin] (he/him)]

https://reviewboard.mozilla.org/r/62802/#review59858

I'd r+ this right away, but it makes way too many whitespace changes.
Do you think you could revert those?

::: devtools/shared/apps/tests/unit/xpcshell.ini:12
(Diff revision 5)
>  support-files =
>    data/app.zip
>    data/app-engineering.zip
>  
>  [test_webappsActor.js]
> -skip-if = buildapp == "b2g"
> +disabled = no more webapps

Shouldn't this test be removed?

::: netwerk/build/nsNetCID.h:53
(Diff revision 5)
>      {0xa1, 0xa8, 0x0, 0x50, 0x4, 0x1c, 0xaf, 0x44}   \
>  }
>  
>  // service implementing nsIProxyAutoConfig.
>  #define NS_PROXYAUTOCONFIG_CONTRACTID \
> -    "@mozilla.org/network/proxy-auto-config;1" 
> +    "@mozilla.org/network/proxy-auto-config;1"

nit: no whitespace changes please.

::: netwerk/build/nsNetCID.h:819
(Diff revision 5)
>  
>  /******************************************************************************
>   * netwerk/mime classes
>   */
>  
> -// {1F4DBCF7-245C-4c8c-943D-8A1DA0495E8A} 
> +// {1F4DBCF7-245C-4c8c-943D-8A1DA0495E8A}

nit: whitespace only change.

Comment 12

[:gerard-majax]

It looks like the whitespace changes are coming from bug 1265613. Are they interfering with your review by adding noise?

Comment 13

[:gerard-majax]

Comment on attachment 8768686 [details]
Bug 1285170 - Remove app:// protocol

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62802/diff/5-6/

Comment 14

[:gerard-majax]

I've removed the test itself. For the whitespace, if you think we should keep them but they are noising the review, I can move them in a separate patch. Or remove the whitespace changes at all if you think we should not touch them.

Comment 15

[:gerard-majax]

Comment on attachment 8768686 [details]
Bug 1285170 - Remove app:// protocol

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62802/diff/6-7/

Comment 16

[:gerard-majax]

Pushed without whitespace (using git format-patch --ignore-all-space)

Comment 17

[:gerard-majax]

https://reviewboard.mozilla.org/r/62802/#review59858

Yep, pushed a new version removing the white spaces using git's format-patch --ignore-all-space.

> Shouldn't this test be removed?

Removed!

Comment 18

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8768686 [details]
Bug 1285170 - Remove app:// protocol

https://reviewboard.mozilla.org/r/62802/#review59992

Thanks!

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a74a1865eb97
Remove app:// protocol r=valentin

Comment 20

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a74a1865eb97