Closed
Bug 1285170
Opened 8 years ago
Closed 8 years ago
[pine => m-c] Kill app:// protocol
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(firefox50 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: gerard-majax, Assigned: gerard-majax)
References
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
I will only handle app:// protocol removal, not the switch of gaia to chrome://
Assignee | ||
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8365b217705b
Assignee | ||
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/62802/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/62802/
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → lissyx+mozillians
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8768686 [details] Bug 1285170 - Remove app:// protocol Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62802/diff/1-2/
Assignee | ||
Comment 5•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=60e76873e2bf
Assignee | ||
Comment 6•8 years ago
|
||
Comment on attachment 8768686 [details] Bug 1285170 - Remove app:// protocol Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62802/diff/2-3/
Assignee | ||
Comment 7•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d63147f8e4f
Assignee | ||
Comment 8•8 years ago
|
||
Comment on attachment 8768686 [details] Bug 1285170 - Remove app:// protocol Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62802/diff/3-4/
Assignee | ||
Comment 9•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f2787d439cb7
Assignee | ||
Comment 10•8 years ago
|
||
Comment on attachment 8768686 [details] Bug 1285170 - Remove app:// protocol Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62802/diff/4-5/
Attachment #8768686 -
Flags: review?(valentin.gosu)
https://reviewboard.mozilla.org/r/62802/#review59858 I'd r+ this right away, but it makes way too many whitespace changes. Do you think you could revert those? ::: devtools/shared/apps/tests/unit/xpcshell.ini:12 (Diff revision 5) > support-files = > data/app.zip > data/app-engineering.zip > > [test_webappsActor.js] > -skip-if = buildapp == "b2g" > +disabled = no more webapps Shouldn't this test be removed? ::: netwerk/build/nsNetCID.h:53 (Diff revision 5) > {0xa1, 0xa8, 0x0, 0x50, 0x4, 0x1c, 0xaf, 0x44} \ > } > > // service implementing nsIProxyAutoConfig. > #define NS_PROXYAUTOCONFIG_CONTRACTID \ > - "@mozilla.org/network/proxy-auto-config;1" > + "@mozilla.org/network/proxy-auto-config;1" nit: no whitespace changes please. ::: netwerk/build/nsNetCID.h:819 (Diff revision 5) > > /****************************************************************************** > * netwerk/mime classes > */ > > -// {1F4DBCF7-245C-4c8c-943D-8A1DA0495E8A} > +// {1F4DBCF7-245C-4c8c-943D-8A1DA0495E8A} nit: whitespace only change.
Assignee | ||
Comment 12•8 years ago
|
||
It looks like the whitespace changes are coming from bug 1265613. Are they interfering with your review by adding noise?
Assignee | ||
Comment 13•8 years ago
|
||
Comment on attachment 8768686 [details] Bug 1285170 - Remove app:// protocol Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62802/diff/5-6/
Assignee | ||
Comment 14•8 years ago
|
||
I've removed the test itself. For the whitespace, if you think we should keep them but they are noising the review, I can move them in a separate patch. Or remove the whitespace changes at all if you think we should not touch them.
Flags: needinfo?(valentin.gosu)
Assignee | ||
Comment 15•8 years ago
|
||
Comment on attachment 8768686 [details] Bug 1285170 - Remove app:// protocol Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62802/diff/6-7/
Assignee | ||
Comment 16•8 years ago
|
||
Pushed without whitespace (using git format-patch --ignore-all-space)
Assignee | ||
Comment 17•8 years ago
|
||
https://reviewboard.mozilla.org/r/62802/#review59858 Yep, pushed a new version removing the white spaces using git's format-patch --ignore-all-space. > Shouldn't this test be removed? Removed!
Attachment #8768686 -
Flags: review?(valentin.gosu) → review+
Comment on attachment 8768686 [details] Bug 1285170 - Remove app:// protocol https://reviewboard.mozilla.org/r/62802/#review59992 Thanks!
Comment 19•8 years ago
|
||
Pushed by alissy@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a74a1865eb97 Remove app:// protocol r=valentin
Comment 20•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a74a1865eb97
Flags: needinfo?(valentin.gosu)
You need to log in
before you can comment on or make changes to this bug.
Description
•