Closed Bug 1285170 Opened 3 years ago Closed 3 years ago

[pine => m-c] Kill app:// protocol

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(firefox50 fixed)

RESOLVED FIXED
Tracking Status
firefox50 --- fixed

People

(Reporter: gerard-majax, Assigned: gerard-majax)

References

Details

Attachments

(1 file)

No description provided.
Depends on: 1265613
I will only handle app:// protocol removal, not the switch of gaia to chrome://
Assignee: nobody → lissyx+mozillians
Depends on: 1276188
Depends on: 1274535
Comment on attachment 8768686 [details]
Bug 1285170 - Remove app:// protocol

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62802/diff/1-2/
Comment on attachment 8768686 [details]
Bug 1285170 - Remove app:// protocol

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62802/diff/2-3/
Comment on attachment 8768686 [details]
Bug 1285170 - Remove app:// protocol

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62802/diff/3-4/
Depends on: 1276189
Comment on attachment 8768686 [details]
Bug 1285170 - Remove app:// protocol

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62802/diff/4-5/
Attachment #8768686 - Flags: review?(valentin.gosu)
https://reviewboard.mozilla.org/r/62802/#review59858

I'd r+ this right away, but it makes way too many whitespace changes.
Do you think you could revert those?

::: devtools/shared/apps/tests/unit/xpcshell.ini:12
(Diff revision 5)
>  support-files =
>    data/app.zip
>    data/app-engineering.zip
>  
>  [test_webappsActor.js]
> -skip-if = buildapp == "b2g"
> +disabled = no more webapps

Shouldn't this test be removed?

::: netwerk/build/nsNetCID.h:53
(Diff revision 5)
>      {0xa1, 0xa8, 0x0, 0x50, 0x4, 0x1c, 0xaf, 0x44}   \
>  }
>  
>  // service implementing nsIProxyAutoConfig.
>  #define NS_PROXYAUTOCONFIG_CONTRACTID \
> -    "@mozilla.org/network/proxy-auto-config;1" 
> +    "@mozilla.org/network/proxy-auto-config;1"

nit: no whitespace changes please.

::: netwerk/build/nsNetCID.h:819
(Diff revision 5)
>  
>  /******************************************************************************
>   * netwerk/mime classes
>   */
>  
> -// {1F4DBCF7-245C-4c8c-943D-8A1DA0495E8A} 
> +// {1F4DBCF7-245C-4c8c-943D-8A1DA0495E8A}

nit: whitespace only change.
It looks like the whitespace changes are coming from bug 1265613. Are they interfering with your review by adding noise?
Comment on attachment 8768686 [details]
Bug 1285170 - Remove app:// protocol

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62802/diff/5-6/
I've removed the test itself. For the whitespace, if you think we should keep them but they are noising the review, I can move them in a separate patch. Or remove the whitespace changes at all if you think we should not touch them.
Flags: needinfo?(valentin.gosu)
Comment on attachment 8768686 [details]
Bug 1285170 - Remove app:// protocol

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62802/diff/6-7/
Pushed without whitespace (using git format-patch --ignore-all-space)
https://reviewboard.mozilla.org/r/62802/#review59858

Yep, pushed a new version removing the white spaces using git's format-patch --ignore-all-space.

> Shouldn't this test be removed?

Removed!
Attachment #8768686 - Flags: review?(valentin.gosu) → review+
https://hg.mozilla.org/mozilla-central/rev/a74a1865eb97
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Flags: needinfo?(valentin.gosu)
Blocks: 1307467
You need to log in before you can comment on or make changes to this bug.