1307467 - Remove RemoteFileOpen, and all app:// related code from JAR channels.

Status: RESOLVED FIXED

(Core :: Networking: JAR, defect)

Description

[Jason Duell]

Bug 1285170 removed the app:// protocol, but JAR channels still contain a bunch of logic that is app-specific, including nsIJarChannel.setJarUri(), and the logic that uses remoteopenfile for app:// requests.

Basically we should get rid of anything that was added in bug 815523 but wasn't already removed in bug 1285170.

Comment 1

[Jason Duell]

Note that AFAICT this also includes ripping out RemoteOpenFile (hallelujah!).  I don't see any other uses of it in the tree. And it really deserves to die :)

Comment 2

[Jason Duell]

I suppose we may need similar code to this to support jar:// in child processes once we have sandboxing.  I say we rip all this code out for now and restore bits as needed when and if we actually get close to sandboxing I/O in child processes.

Comment 3

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1307467 - Remove RemoteFileOpen, and all app:// related code from JAR channels.

Removes things added in bug 815523

Review commit: https://reviewboard.mozilla.org/r/87268/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/87268/

Comment 4

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1307467 - Remove code that preopens and sends application.zip fd (bug 835698)

Review commit: https://reviewboard.mozilla.org/r/87270/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/87270/

Comment 5

[Valentin Gosu [:valentin] (he/him)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d1383a7826f

Comment 6

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1307467 - Remove mAppURI from nsJARChannel

Review commit: https://reviewboard.mozilla.org/r/87400/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/87400/

Comment 7

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8803011 [details]
Bug 1307467 - Remove RemoteFileOpen, and all app:// related code from JAR channels.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/87268/diff/1-2/

Comment 8

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8803012 [details]
Bug 1307467 - Remove code that preopens and sends application.zip fd (bug 835698)

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/87270/diff/1-2/

Comment 9

[Daniel Stenberg [:bagder]]

Comment on attachment 8803011 [details]
Bug 1307467 - Remove RemoteFileOpen, and all app:// related code from JAR channels.

https://reviewboard.mozilla.org/r/87268/#review86900

Lovely!

Comment 10

[Daniel Stenberg [:bagder]]

Comment on attachment 8803012 [details]
Bug 1307467 - Remove code that preopens and sends application.zip fd (bug 835698)

https://reviewboard.mozilla.org/r/87270/#review86902

I like the smell of removing a lot of code!

Comment 11

[Daniel Stenberg [:bagder]]

Comment on attachment 8803169 [details]
Bug 1307467 - Remove mAppURI from nsJARChannel

https://reviewboard.mozilla.org/r/87400/#review86904

Comment 12

[Andrea Marchesini [:baku]]

Comment on attachment 8803012 [details]
Bug 1307467 - Remove code that preopens and sends application.zip fd (bug 835698)

https://reviewboard.mozilla.org/r/87270/#review88528

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dce4d4b3e4e8
Remove RemoteFileOpen, and all app:// related code from JAR channels. r=bagder
https://hg.mozilla.org/integration/autoland/rev/4b76a90d5caf
Remove code that preopens and sends application.zip fd (bug 835698) r=bagder,baku
https://hg.mozilla.org/integration/autoland/rev/7d4b390b36e8
Remove mAppURI from nsJARChannel r=bagder

Comment 14

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/dce4d4b3e4e8
https://hg.mozilla.org/mozilla-central/rev/4b76a90d5caf
https://hg.mozilla.org/mozilla-central/rev/7d4b390b36e8