Closed Bug 1307467 Opened 3 years ago Closed 3 years ago

Remove RemoteFileOpen, and all app:// related code from JAR channels.

Categories

(Core :: Networking: JAR, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: jduell.mcbugs, Assigned: valentin)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-active])

Attachments

(3 files)

Bug 1285170 removed the app:// protocol, but JAR channels still contain a bunch of logic that is app-specific, including nsIJarChannel.setJarUri(), and the logic that uses remoteopenfile for app:// requests.

Basically we should get rid of anything that was added in bug 815523 but wasn't already removed in bug 1285170.
Note that AFAICT this also includes ripping out RemoteOpenFile (hallelujah!).  I don't see any other uses of it in the tree. And it really deserves to die :)
Summary: Remove setAppUri and all app:// related code from JAR channels. → Remove RemoteFileOpen, and all app:// related code from JAR channels.
I suppose we may need similar code to this to support jar:// in child processes once we have sandboxing.  I say we rip all this code out for now and restore bits as needed when and if we actually get close to sandboxing I/O in child processes.
Whiteboard: [necko-next]
Comment on attachment 8803011 [details]
Bug 1307467 - Remove RemoteFileOpen, and all app:// related code from JAR channels.

https://reviewboard.mozilla.org/r/87268/#review86900

Lovely!
Attachment #8803011 - Flags: review?(daniel) → review+
Comment on attachment 8803012 [details]
Bug 1307467 - Remove code that preopens and sends application.zip fd (bug 835698)

https://reviewboard.mozilla.org/r/87270/#review86902

I like the smell of removing a lot of code!
Attachment #8803012 - Flags: review?(daniel) → review+
Comment on attachment 8803169 [details]
Bug 1307467 - Remove mAppURI from nsJARChannel

https://reviewboard.mozilla.org/r/87400/#review86904
Attachment #8803169 - Flags: review?(daniel) → review+
Comment on attachment 8803012 [details]
Bug 1307467 - Remove code that preopens and sends application.zip fd (bug 835698)

https://reviewboard.mozilla.org/r/87270/#review88528
Attachment #8803012 - Flags: review?(amarchesini) → review+
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/dce4d4b3e4e8
Remove RemoteFileOpen, and all app:// related code from JAR channels. r=bagder
https://hg.mozilla.org/integration/autoland/rev/4b76a90d5caf
Remove code that preopens and sends application.zip fd (bug 835698) r=bagder,baku
https://hg.mozilla.org/integration/autoland/rev/7d4b390b36e8
Remove mAppURI from nsJARChannel r=bagder
No longer blocks: 1369194
You need to log in before you can comment on or make changes to this bug.