1285195 - Fedora Firefox builds are not sending Telemetry

Status: VERIFIED FIXED

(Toolkit :: Telemetry, defect, P3)

Description

[Alessio Placitelli [:Dexter]]

As found in bug 1284010, the Fedora Firefox builds are not sending Telemetry.

This bug is about enabling Telemetry on those builds.

Comment 1

[Alessio Placitelli [:Dexter]]

The page of the package: https://apps.fedoraproject.org/packages/firefox/

Comment 2

[Alessio Placitelli [:Dexter]]

And the Firefox package maintainers page: https://fedoraproject.org/wiki/Firefox

Comment 3

[Alessio Placitelli [:Dexter]]

Apparently someone enabled Telemetry around January 2017: http://pkgs.fedoraproject.org/cgit/rpms/firefox.git/commit/?id=b2b845f7ba35

Comment 4

[Alessio Placitelli [:Dexter]]

Madalin, would you kindly perform some general Telemetry QA on the latest version of Fedora Firefox, for the Release channel, on the Fedora OS?

I compiled a non comprehensive list of test cases in bug 1243772 comment 2, let me report them here as well.

(In reply to Alessio Placitelli [:Dexter] from bug 1243772 comment #2)
> 
> Test: nothing is sent before the policy infobar is shown
> Outcome: nothing is sent before, pings are correctly sent after
> 
> Test: make sure release Firefox has extended Telemetry opt-in, pre-release
> opt-out
> Outcome: pre-release channels correctly have Telemetry as opt-out. No build
> is available at the moment to test the release channel
> 
> Test: make sure the environment reports the Fedora distribution id
> Outcome: The environment.partner.distributionId section of the environment
> contains the "fedora" string
> 
> Test: make sure no extended telemetry is recorded if Telemetry is turned off
> Outcome: no extended Telemetry is present in pings generated with Telemetry
> being off. No saved-session pings are saved at shutdown.
> 
> Test: make sure nothing gets sent when FHR data upload is disabled.
> Outcome: The ping upload preference is respected, no pings are uploaded
> (except the deletion ping) when the Firefox Health Report option is disabled.
> 
> Test: make sure opt-out Telemetry is sent with only FHR upload enabled.
> Outcome: Only base telemetry is sent.

Comment 5

[Madalin Cotetiu]

I have started creating a document with test cases based on scenarios from comment 4. Sorry for the delay, hopefully the testing will be completed by the end of the week. Thanks

Comment 6

[Mike Kaply [:mkaply]]

FYI, I am working with Jan Horak on a separate project to build a Flatpak of Firefox.

If we go that route, we will own the package that is shipped on anything Red Hat so we can make sure telemetry is enabled.

See bug 1278719

Comment 7

[Alessio Placitelli [:Dexter]]

(In reply to Mike Kaply [:mkaply] from comment #6)
> FYI, I am working with Jan Horak on a separate project to build a Flatpak of
> Firefox.
> 
> If we go that route, we will own the package that is shipped on anything Red
> Hat so we can make sure telemetry is enabled.
> 
> See bug 1278719

This is nice and will definitely simplify things moving forward! Let me add this bit of info to the metabug that tracks Telemetry on Linux distros ;)

Comment 8

[Victor Carciu]

We tested scenarios created based on Comment #4 and you can see the results here : https://docs.google.com/spreadsheets/d/1O17gFbUWAzCmRllHuigkbnS7pStvKAxhoZgKcmbgBiU/edit#gid=0 and we will continue with some exploratory testing around these scenarios.

@Dexter :
Please note the results at test case 5 for Fedora and let me know if a new bug is needed.

Comment 9

[Alessio Placitelli [:Dexter]]

(In reply to Victor Carciu from comment #8)
> @Dexter :
> Please note the results at test case 5 for Fedora and let me know if a new
> bug is needed.

Thanks Victor! Yes, that's definitely a bug. Would you mind filing it and CC me on it?

Comment 10

[Victor Carciu]

(In reply to Alessio Placitelli [:Dexter] from comment #9)
> (In reply to Victor Carciu from comment #8)
> > @Dexter :
> > Please note the results at test case 5 for Fedora and let me know if a new
> > bug is needed.
> 
> Thanks Victor! Yes, that's definitely a bug. Would you mind filing it and CC
> me on it?

Logged https://bugzilla.mozilla.org/show_bug.cgi?id=1354489 .

Thanks!

Comment 11

[Alessio Placitelli [:Dexter]]

Closing off this bug since Fedora is indeed sending Telemetry. We'll fix the remaining issues in bug 1354489.

Comment 12

[Victor Carciu]

Verified as fixed. Please see attached screenshot

Comment 13

[Victor Carciu]

(In reply to Victor Carciu from comment #12)
> Verified as fixed. Please see attached screenshot

My previous comment was a mistake , I added it for the wrong bug. Sorry