1284010 - Data Choices Preferences Tab not Loading in Fedora

Status: RESOLVED DUPLICATE of bug 1312182

(Firefox Health Report Graveyard :: Client: Desktop, defect, P3)

Description

[u564464]

Attachment: data_choices_blank.png

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:47.0) Gecko/20100101 Firefox/47.0
Build ID: 20160606100246

Steps to reproduce:

In Korora 23 and Fedora 24. I went to Preferences -> Advanced -> Data Choices in Private Browsing mode.

Also went to that preferences tab from the "Choose what I share" dialog after the second run.


Actual results:

Data Choices tab is blank , doesn't load or show anything (see attached screenshot).


Expected results:

Should load and show checkboxes for enabling/disabling crash reporter and health report.

Comment 1

[Tooru Fujisawa [:arai]]

Those are shown only if telemetry and crash reporter are enabled on the build.
maybe they're disabled on your build.

where do you download/install Firefox?

Comment 2

[u564464]

The affected Firefox instances were pre-installed with the OS and updated through the Fedora DNF repos.

Comment 3

[Tooru Fujisawa [:arai]]

about:buildconfig says --disable-crashreporter is specified.  so at least crash reporter is disabled and 2nd checkbox won't be shown.
https://dxr.mozilla.org/mozilla-central/rev/39dffbba764210b25bfc1e749b4f16db77fa0d46/browser/components/preferences/in-content/advanced.xul#230

Also, from the following source of about:preference:
>     <!-- Data Choices -->
>     <tabpanel id="dataChoicesPanel" orient="vertical">
>     </tabpanel>

telemetry seems to also be disabled, as the #ifdef is not extracted.
https://dxr.mozilla.org/mozilla-central/rev/39dffbba764210b25bfc1e749b4f16db77fa0d46/browser/components/preferences/in-content/advanced.xul#199

So, not-displaying them seems to be correct behavior.

the remaining question is that why "Choose what I share" button is shown.
maybe mis-configuration or such configuration is not tested...?

Comment 4

[Tooru Fujisawa [:arai]]

bug 1234518 seems to be related.

Comment 5

[Tooru Fujisawa [:arai]]

currently MOZ_DATA_REPORTING is set to 1 when one of the following is set to 1
  * MOZ_TELEMETRY_REPORTING
  * MOZ_SERVICES_HEALTHREPORT
  * MOZ_CRASHREPORTER

https://dxr.mozilla.org/mozilla-central/rev/39dffbba764210b25bfc1e749b4f16db77fa0d46/old-configure.in#6689
> if test -n "$MOZ_TELEMETRY_REPORTING" || test -n "$MOZ_SERVICES_HEALTHREPORT" || test -n "$MOZ_CRASHREPORTER"; then
>   MOZ_DATA_REPORTING=1


but the about:preference display depends only on MOZ_TELEMETRY_REPORTING and MOZ_CRASHREPORTER, while there is an option for health report inside `#ifdef MOZ_TELEMETRY_REPORTING`.

https://dxr.mozilla.org/mozilla-central/rev/39dffbba764210b25bfc1e749b4f16db77fa0d46/browser/components/preferences/in-content/advanced.xul#199


Dexter, what's the status of FHR, and what's the actual dependency between telemetry and FHR?

Comment 6

[Hussam Al-Tayeb]

(In reply to Tooru Fujisawa [:arai] from comment #1)
> Those are shown only if telemetry and crash reporter are enabled on the
> build.
> maybe they're disabled on your build.
> 
> where do you download/install Firefox?

Is it possible to hide the 'data choices' tab if it is empty?

Comment 7

[Tooru Fujisawa [:arai]]

(In reply to Hussam Al-Tayeb from comment #6)
> (In reply to Tooru Fujisawa [:arai] from comment #1)
> > Those are shown only if telemetry and crash reporter are enabled on the
> > build.
> > maybe they're disabled on your build.
> > 
> > where do you download/install Firefox?
> 
> Is it possible to hide the 'data choices' tab if it is empty?

It was designed to do so, but now it has some inconsistency between the condition to hide tab (MOZ_DATA_REPORTING) and hide each checkboxes.

Comment 9

[Alessio Placitelli [:Dexter]]

(In reply to Tooru Fujisawa [:arai] from comment #5)
> Dexter, what's the status of FHR, and what's the actual dependency between
> telemetry and FHR?

tl;dr;

Telemetry is now the only data collection system in Firefox, the FHR data collection was deprecated and removed, except for the "about:healthreport" page that we're (and we will) still be using. If there are no options shown in the Data Choices tab, then we're not sending any data. But due to the reported inconsistency, we'd still be able to see the "Data Choice" pane.

- Background -

On Firefox Desktop, since we enabled Unified Telemetry on all channels, the FHR data collection service was first disabled and then removed. The "about:healthreport" page is still available and will remain as such, but is now powered by the data from Unified Telemetry.

The MOZ_SERVICES_HEALTHREPORT was used to enable/disable both the FHR collection service and the "about:healthreport" page, now it only controls the latter. MOZ_TELEMETRY_REPORTING controls the data collection.

We're renaming MOZ_SERVICE_HEALTHREPORT to MOZ_ENABLE_HEALTHREPORT in bug 1242591 now to make things clearer.

- The issue(s) -

We're not sending data from these builds. Anyway, MOZ_SERVICE_HEALTHREPORT should probably be removed from https://dxr.mozilla.org/mozilla-central/rev/39dffbba764210b25bfc1e749b4f16db77fa0d46/old-configure.in#6689, as it doesn't control data gathering on Desktop any more.

That said, we'd probably want to fix these distribution builds to make them send Telemetry, if enabled.

Comment 10

[Alessio Placitelli [:Dexter]]

@Georg, do you have an opinion on the issue described in comment 9? (I didn't insert this in the previous comment :-D )

Comment 11

[Georg Fritzsche [:gfritzsche]]

(In reply to Alessio Placitelli [:Dexter] from comment #9)
> We're not sending data from these builds. Anyway, MOZ_SERVICE_HEALTHREPORT
> should probably be removed from
> https://dxr.mozilla.org/mozilla-central/rev/
> 39dffbba764210b25bfc1e749b4f16db77fa0d46/old-configure.in#6689, as it
> doesn't control data gathering on Desktop any more.

That sounds reasonable.

> That said, we'd probably want to fix these distribution builds to make them
> send Telemetry, if enabled.

Yes, that would be great. Did Fedora send FHR data before?
If yes, we should see how to get that re-enabled.

Comment 12

[Alessio Placitelli [:Dexter]]

(In reply to Georg Fritzsche [:gfritzsche] from comment #11)
> (In reply to Alessio Placitelli [:Dexter] from comment #9)
> > We're not sending data from these builds. Anyway, MOZ_SERVICE_HEALTHREPORT
> > should probably be removed from
> > https://dxr.mozilla.org/mozilla-central/rev/
> > 39dffbba764210b25bfc1e749b4f16db77fa0d46/old-configure.in#6689, as it
> > doesn't control data gathering on Desktop any more.
> 
> That sounds reasonable.

Cool, I'll add a patch to do that in this bug.

> > That said, we'd probably want to fix these distribution builds to make them
> > send Telemetry, if enabled.
> 
> Yes, that would be great. Did Fedora send FHR data before?
> If yes, we should see how to get that re-enabled.

I've filed bug 1285195 for that.

Comment 13

[Alessio Placitelli [:Dexter]]

Attachment: bug1284010.patch

Comment 14

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8769168 [details] [diff] [review]
bug1284010.patch

Review of attachment 8769168 [details] [diff] [review]:
-----------------------------------------------------------------

Did you do a sanity check on this for building with & without _HEALTHREPORT and checking opt-in/opt-out Telemetry, about:healthreport and the pref pages?

::: toolkit/components/telemetry/TelemetryController.jsm
@@ +666,5 @@
>      }
>  
>      // This will trigger displaying the datachoices infobar.
> +    if (AppConstants.MOZ_DATA_REPORTING) {
> +      TelemetryReportingPolicy.setup();

Isn't it cleaner to do the check inside TelemetryReportingPolicy?

Comment 16

[Alessio Placitelli [:Dexter]]

Fixing this bug will happen as a consequence of bug 1312182.

Comment 17

[Alessio Placitelli [:Dexter]]

This was fixed by bug 1312182.