128538 - composer doesn't save changes

Status: VERIFIED FIXED

(SeaMonkey :: Composer, defect)

Description

[Asa Dotzler [:asa]]

composer doesn't save. more info coming

Comment 1

[Asa Dotzler [:asa]]

Initial save in composer works but cannot make changes to that saved document
and then save the changes.  Tested Windows and Linux and both fail. Will test
Mac next.

Comment 2

[Brendan Eich [:brendan]]

Since when, what checkin yesterday?  We need to calibrate our drivers
web-of-trust, if possible.

/be

Comment 3

[Asa Dotzler [:asa]]

This worked in yesterday morning's verification builds. Here's a rough cut at
that hook
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=SeaMonkeyAll&branch=Head&sortby=Who&hours=2&date=explicit&mindate=02%2F28%2F2002+08%3A00&maxdate=03%2F01%2F2002+08%3A00

Comment 4

[Boris Zbarsky [:bzbarsky]]

are we forgetting to pass in PERSIST_FLAGS_REPLACE_EXISTING_FILES somewhere?

Comment 5

[Bill Law]

Something like that.  I backed out the latest rev (1.99) of
editor/ui/composer/content/ComposerCommands.js and it then worked.  That's the
editor code that does the call to nsWebBrowserPersist.

Kathy Brade checked that in yesterday.  I'll get on somebody's case about it...

Comment 6

[Bill Law]

That was for bug 125070.  The changes don't match what's in the patch for that
bug, so maybe that's the reason.  

Comment 7

[Bill Law]

This needs to be fixed on the branch and the trunk, BTW.

Comment 8

[sairuh (rarely reading bugmail)]

also experienced this just now with 2002.03.01.08 comm bits on rh7.2. i just
lost several hours of work!

Comment 9

[Bill Law]

My regrets; that's what I was afraid of.  I'm just now preparing to back out the
code in question.

Comment 10

[Bill Law]

I've backed out the latest rev of ComposerCommands.js on the branch.  I'll do
that on the trunk as soon as tbox goes green.  I've re-opened bug 125070.

Comment 11

[michael wendell]

Verified, I am able to save on Win XP using the 03-04 trunk build.   

If anyone is still seeing this problem, feel free to reopen it.