1285396 - [encoding] Support for Shift-JIS

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Addison Phillips]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:47.0) Gecko/20100101 Firefox/47.0
Build ID: 20160604131506

Steps to reproduce:

The W3C I18N WG in cooperation with WhatWG has created tests for the Encoding specification. In testing the encoding:

   Shift-JIS

Our tests found 10 total errors. In addition 1 of the 8 decoder tests failed. Note that bug 1285393 blocks a number of tests.




Actual results:

Please see:

https://github.com/whatwg/encoding/issues/61


Expected results:

Please reply on the above github issue in addition to addressing this bug here. If there are errors in our tests or in the specification, we would very much like to know!

[filed for W3C I18N WG]

Comment 1

[Andrew Overholt [:overholt]]

Henri may have thoughts here given his related work.

Comment 2

[Andrew Overholt [:overholt]]

There are a number of similar bugs here but I'll just needinfo you on one of them, Henri.

Comment 3

[Henri Sivonen (:hsivonen) (temporarily away from Bugzilla)]

Per bug 1261841, I'm working on rewriting our encoding converters in Rust. I'm at the rather inconvenient point where things are so far along (implementations for all encodings written) that it doesn't make sense to put effort into fixing anything other than critical security vulnerabilities in the old ones but also the new implementations aren't testable in a browser yet.

The new Shift_JIS implementation is at https://github.com/hsivonen/encoding_rs/blob/master/src/shift_jis.rs

It can be tested outside a browser using a sample app whose source is available from https://github.com/hsivonen/recode_rs

Comment 4

[Masatoshi Kimura [:emk]]

Fixed by bug 1261841.