Closed Bug 1285399 Opened 4 years ago Closed 3 years ago

[encoding] Support for EUC-JP

Categories

(Core :: DOM: Core & HTML, defect, P3)

47 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla56

People

(Reporter: addison, Assigned: hsivonen)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fixed by encoding_rs])

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:47.0) Gecko/20100101 Firefox/47.0
Build ID: 20160604131506

Steps to reproduce:

The W3C I18N WG in cooperation with WhatWG has created tests for the Encoding specification. In testing the encoding:

   EUC-JP

Our tests found 8 total character mapping errors. In addition 1 of the 11 decoder tests failed. Note that bug 1285393 blocks a number of tests.


Actual results:

Please see:

https://github.com/whatwg/encoding/issues/59


Expected results:

Please reply on the above github issue in addition to addressing this bug here. If there are errors in our tests or in the specification, we would very much like to know!

[filed for W3C I18N WG]
Component: Untriaged → DOM: Core & HTML
Product: Firefox → Core
Henri may have thoughts here given his related work.
Blocks: encoding
Per bug 1261841, I'm working on rewriting our encoding converters in Rust. I'm at the rather inconvenient point where things are so far along (implementations for all encodings written) that it doesn't make sense to put effort into fixing anything other than critical security vulnerabilities in the old ones but also the new implementations aren't testable in a browser yet.

The new EUC-JP implementation is at https://github.com/hsivonen/encoding_rs/blob/master/src/euc_jp.rs

It can be tested outside a browser using a sample app whose source is available from https://github.com/hsivonen/recode_rs
Depends on: encoding_rs
Priority: -- → P3
encoding_rs fixed the decoder, but the decoder still fails.
(In reply to Masatoshi Kimura [:emk] from comment #3)
> encoding_rs fixed the decoder, but the decoder still fails.

As commented on GitHub (https://github.com/whatwg/encoding/issues/59#issuecomment-308677735), Firefox is correct per spec as amended in May.

Fixed by bug 1261841.
Assignee: nobody → hsivonen
Status: UNCONFIRMED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Whiteboard: [fixed by encoding_rs]
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.