Closed
Bug 1285419
Opened 8 years ago
Closed 8 years ago
Telemetry to support background video decoder suspend: Hidden play time
Categories
(Core :: Audio/Video: Playback, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: mozbugz, Assigned: mozbugz)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
To help tweak the decoder-suspend functionality, we want to measure how much videos actually play while hidden. The telemetry probe will be similar to VIDEO_PLAY_TIME_MS, but will only record the accumulated play time while the video is hidden.
Assignee | ||
Comment 1•8 years ago
|
||
This probe is similar to VIDEO_PLAY_TIME_MS, but it will only record the total play time while the video is hidden. Review commit: https://reviewboard.mozilla.org/r/62998/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/62998/
Attachment #8769017 -
Flags: review?(dglastonbury)
Attachment #8769017 -
Flags: review?(benjamin)
Updated•8 years ago
|
Priority: -- → P3
Comment 2•8 years ago
|
||
Comment on attachment 8769017 [details] Bug 1285419 - Telemetry probe: VIDEO_HIDDEN_PLAY_TIME_MS - https://reviewboard.mozilla.org/r/62998/#review61084 data-review+ I have not reviewed the matching code.
Attachment #8769017 -
Flags: review?(benjamin) → review+
Comment on attachment 8769017 [details] Bug 1285419 - Telemetry probe: VIDEO_HIDDEN_PLAY_TIME_MS - https://reviewboard.mozilla.org/r/62998/#review61136 LGTM, where is the C++ code?
Attachment #8769017 -
Flags: review?(dglastonbury) → review+
Assignee | ||
Comment 4•8 years ago
|
||
Note that this is a simple duration counter based on the existing (non-hidden) play-time, but it only counts when video is playing while hidden. There is no bucketing yet, future probes may add finer-grained information. Review commit: https://reviewboard.mozilla.org/r/64116/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/64116/
Attachment #8770766 -
Flags: review?(dglastonbury)
Assignee | ||
Comment 5•8 years ago
|
||
Comment on attachment 8769017 [details] Bug 1285419 - Telemetry probe: VIDEO_HIDDEN_PLAY_TIME_MS - Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62998/diff/1-2/
Attachment #8770766 -
Flags: review?(dglastonbury) → review+
Comment on attachment 8770766 [details] Bug 1285419 - Record mediasource hidden play time - https://reviewboard.mozilla.org/r/64116/#review61138 ![Ship It](https://qph.ec.quoracdn.net/main-qimg-0bf1d3de309a89d9ed70ae91f6271a7f) ::: dom/html/HTMLMediaElement.h:1618 (Diff revision 1) > uint32_t mCount; > }; > private: > // Total time a video has spent playing. > TimeDurationAccumulator mPlayTime; > + // Total time a video has spent playing while hidden. Blank line above comment for consistency.
Assignee | ||
Comment 7•8 years ago
|
||
Comment on attachment 8770766 [details] Bug 1285419 - Record mediasource hidden play time - Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64116/diff/1-2/
Pushed by gsquelart@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a621d144bfee Telemetry probe: VIDEO_HIDDEN_PLAY_TIME_MS - r=bsmedberg,kamidphish https://hg.mozilla.org/integration/autoland/rev/52e28dee863f Record mediasource hidden play time - r=kamidphish
Comment 9•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a621d144bfee https://hg.mozilla.org/mozilla-central/rev/52e28dee863f
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•