1299065 - Telemetry to support background video decoder suspend: invisible elements in the foreground should also be recorded

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Tzuhao Kuo [:kaku]]

The HTMLMediaElement::NotifyOwnerDocumentActivityChangedInternal() calls HTMLMediaElement::HiddenVideoStart() to record  VIDEO_HIDDEN_PLAY_TIME_MS, VIDEO_HIDDEN_PLAY_TIME_PERCENTAGE and VIDEO_INFERRED_DECODE_SUSPEND_PERCENTAGE for video elements in background tabs. 

We should also do it for invisible video elements in the foreground tab via HTMLMediaElement::OnVisibilityChange().

Comment 1

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1299065 - invisible elements in the foreground should also be recorded;

Review commit: https://reviewboard.mozilla.org/r/75260/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/75260/

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8786251 [details]
Bug 1299065 - invisible elements in the foreground should also be recorded;

https://reviewboard.mozilla.org/r/75260/#review73110

Good catch, thank you.

Comment 3

[Tzuhao Kuo [:kaku]]

Thanks for the review!

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2b9b774f0472&selectedJob=26642732
The fails should have nothing to do with this change.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06bf533a2bdd
invisible elements in the foreground should also be recorded; r=gerald

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/06bf533a2bdd

Comment 6

[Timothy Nikkel (:tnikkel)]

For reference, I backed this bug out and then relanded a tweaked version (to handle the difference in the visibility api that this patch use). Bug 1284350 is where the back out and relanding happened. I also plan to request uplift of those patches to aurora.