Closed Bug 1299065 Opened 4 years ago Closed 4 years ago
Telemetry to support background video decoder suspend: invisible elements in the foreground should also be recorded
58 bytes, text/x-review-board-request
The HTMLMediaElement::NotifyOwnerDocumentActivityChangedInternal() calls HTMLMediaElement::HiddenVideoStart() to record VIDEO_HIDDEN_PLAY_TIME_MS, VIDEO_HIDDEN_PLAY_TIME_PERCENTAGE and VIDEO_INFERRED_DECODE_SUSPEND_PERCENTAGE for video elements in background tabs. We should also do it for invisible video elements in the foreground tab via HTMLMediaElement::OnVisibilityChange().
Comment on attachment 8786251 [details] Bug 1299065 - invisible elements in the foreground should also be recorded; https://reviewboard.mozilla.org/r/75260/#review73110 Good catch, thank you.
Attachment #8786251 - Flags: review?(gsquelart) → review+
Thanks for the review! Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2b9b774f0472&selectedJob=26642732 The fails should have nothing to do with this change.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/06bf533a2bdd invisible elements in the foreground should also be recorded; r=gerald
For reference, I backed this bug out and then relanded a tweaked version (to handle the difference in the visibility api that this patch use). Bug 1284350 is where the back out and relanding happened. I also plan to request uplift of those patches to aurora.
You need to log in before you can comment on or make changes to this bug.