128542 - Lines in outliner are too narrow, some characters at cut off at the bottom (e.g. cookie manager dialog).

Status: RESOLVED DUPLICATE of bug 86532

(Core :: XUL, defect, P3)

Description

[André Dahlqvist]

[Build-ID: 2002-03-01-16]

I've seen this for ages, but I have never seen it reported. Sorry if it is a dupe.

A screenshot best describes this bug, so below I will attach a screenshot of
this bug. In the cookie manager the lines seam to lie too close to eachother,
and characters with "tails" (such as 'g') often loose the bottom most part of
itself. The line below it overlaps it, in other words.

Notice that it only seams to happen on entries high up in the list of cookies,
which is weird. I think if first saw this bug after the cookie viewer had been
converted to Outliner, but I am not 100% on that.

I wouldn't be surprised if this is Linux-only.

Comment 1

[André Dahlqvist]

Attachment: Screenshot showing how some lines are too close to each other.

Comment 2

[Peter Trudelle]

->Cookies/future

Comment 3

[Stephen P. Morse]

Although this shows up in the cookie dialog, it's nothing unique to cookies but 
must be a general problem with outlines.  Reassigning.

Comment 4

[André Dahlqvist]

Yes, I agree. I think I have seen the same thing happen in the newsgroups view.

Comment 5

[Stephen P. Morse]

Changing summary to reflect that this is a general problem and not a cookie 
viewer one.

Comment 6

[Brendan Eich [:brendan]]

bryner, can you take a quick look?  Cc'ing hyatt, varga, and trudelle.

/be

Comment 7

[Jan Varga [:janv]]

sounds like bug 73984

Comment 8

[André Dahlqvist]

Jan, that bug certainly sounds similar. I don't like the fact that it's still in
the Mail/News category, and doesn't have a screenshot, but feel free to dupe
this one if you feel it has more info than this bug.

Comment 9

[Peter Trudelle]

If this is a general problem, then we need steps to reproduce.  ->qawanted. 
JRGM, could you look into this and nominate as appropriate?  Jan, could you take
this if needed, since bryner is in form control hell?

Comment 10

[Stephen P. Morse]

FWIW, I'm not seeing this on windows.  The interline spacing that I am seeing is 
much greater than the one in the posted screenshot.  So maybe it is a linux-only 
problem.

Comment 11

[Jan Varga [:janv]]

I guess, it's font problem.
Taking for now.

Comment 12

[André Dahlqvist]

Jan, what info is valuable for you? Here is some info on my system:

I'm running Debian GNU/Linux unstable with XFree86 4.1.0. This bug happens with
a clean profile, so in other words no font settings have been changed in
mozilla. My font server (xfs) serves fonts with 100dpi.

Below I will attach the output of 'xdpyinfo' in case it is helpful.

Comment 13

[André Dahlqvist]

Attachment: Output from xdpyinfo on a machine that shows this bug.

Comment 14

[John Morrison]

Attachment: simple testcase (mostly borrowed)

-- foo.css -- to go with attached test case; vary font-size until you get
descenders to overlap with text below.

outlinerchildren {
  font-family: sans-serif;
  font-size: 16pt;
}

Comment 15

[John Morrison]

So, yeah, as you increase the font-size for the text in the outliner, at about 
14pt/sans-serif on windows, and about 18pt/serif on linux (for the machines and 
fonts that I tried), there is some problem with descenders from the line above 
overlapping with text in the line below. 

(Sidenote: I don't really understand what the screenshot is supposed to show; 
all the rows are blank). 

It seems that the rows are either not measuring the text correctly, or are 
capped to a max-height and don't grow with the text. 

In general, this isn't an issue, but it could be an issue for visually impaired 
who are using large fonts to compensate.

Comment 16

[Jan Varga [:janv]]

Thanks for info.
This is the same problem as in 73984.
And it sounds reasonable to me.
An outliner uses fixed height (currently 18px) for performance reasons

outlinerchildren:-moz-outliner-row {
  border: 1px solid transparent;
  height: 18px;
} 

It would be a big overhead to adjust height to real text height.
Still looking for a way to solve this problem w/o perf impact.

Comment 17

[Jan Varga [:janv]]

jrgm, there is a problem with the screenshot (png problem I guess)
I see blank rows too, but only in ns4x

Comment 18

[André Dahlqvist]

The thing is that I have not set my fonts any larger than the standard value.

Comment 19

[Jan Varga [:janv]]

The standard value may be not well tuned too.
Anyway, I've got an idea to fix this bug, working on a patch...

Comment 20

[Jan Varga [:janv]]

it seems that fix is very easy
- height: 18px;
+ height: 1.5em;

:)

Comment 21

[John Morrison]

doh :-). Yes, that CSS thing is kind of cool.

Comment 22

[Jan Varga [:janv]]

Attachment: patch

Comment 23

[John Morrison]

Although, is it certain that when using 'em' for the max-height, that the row 
height for the entire outliner will only be calculated once?

Comment 24

[André Dahlqvist]

Attachment: Screenshot with patch applied.

I applied the patch from attachment 72957 [details] [diff] [review] on a CVS tree from the 0.9.9 branch,
and this is how it looks. The distance between the rows are not instead too
big. At least IMHO:-)

Comment 25

[Jan Varga [:janv]]

Attachment: screenshot2

I think you have bigger font in general

Comment 26

[Jan Varga [:janv]]

a good value for windows is 1.7em;
Now I'm not sure again :(

Comment 27

[Jan Varga [:janv]]

*** This bug has been marked as a duplicate of 86532 ***