128554 - Cookie & Image related dialogs shouldn't be modal

Status: VERIFIED FIXED

(Core :: Networking: Cookies, defect)

Description

[Robert John Churchill]

Comment 1

[Robert John Churchill]

Attachment: Patch to remove modality (especially important for Mac OS X)

Patch for cookie & image dialogs to not open them modally... especially
important for Mac OS X.

Comment 2

[Stephen P. Morse]

Robert, if you are going to make them non modal, then you'll also need to add 
code to keep updating the display whenever new cookies arrive.  Otherwise the 
display will quickly get out of synch with reality.

Comment 3

[Robert John Churchill]

Steve:  I'd view that more as a new feature (best done with a different bug) and
not really required to make the dialogs non-modal.

Comment 4

[Robert John Churchill]

BTW You should note that, even today, other open browser windows could be
invalidating the cookie display since the Cookie dialog would be modal to only
its parent window.

Comment 5

[Stephen P. Morse]

Yes, that's a known problem.  But your change will make things worse yet.

If this is so important for Mac OSX, can't we make the change for that platform 
only?

Comment 6

[Quinn Yost (mythdraug)]

One additional item to beware of with this.   On a couple occasions
I've had a non-modal dialog, and have managed to close the window 
with the object in question.  When this happened, answering the 
dialog would crash mozilla.  (bug 110269)

Comment 7

[Robert John Churchill]

> But your change will make things worse yet.

I disagree. Other aspects of the browser work similarly (thus the Reload button
for example.)


> If this is so important for Mac OSX, can't we make the change for that platform 
only?

I don't see why other platforms should suffer where they can't use the parent
little sense.

Comment 8

[Steve Dagley]

Comment on attachment 72180 [details] [diff] [review]
Patch to remove modality (especially important for Mac OS X)

r=sdagley

Comment 9

[Stephen P. Morse]

Please look at comment #6.  That is a serious problem which I've seen many times 
as well.  Are you sure that making this change is not going to open us up to 
many crashes of this sort?  Have you tried this on windows and linux and made 
sure that it doesn't crash, regardless of which window you close first?

Comment 10

[Robert John Churchill]

Bug 110269 (which dbaron says is sporadic) is unrelated... and the patch on this
bug works for me on other platforms.

Comment 11

[Stephen P. Morse]

The bug I was referring to was bug 60150.  And that one is not sporadic -- I 
have been able to reproduce it many times.

Comment 12

[Robert John Churchill]

Bug 60150 is about modal dialogs... which won't be true of the dialogs in
question with this patch.

Comment 13

[Peter Trudelle]

Nav triage team needs info: why is it urgent to make these modeless in MachV?

Comment 14

[Robert John Churchill]

It is bad UI (for all platforms) since it blocks usage of the parent window
unnecessarily, and the parent window isn't just a browser window but any window
due to these dialogs being globally available via the "Tasks" menu.  However, it
is especially bad on Mac OS X where modal dialogs become "sheets" where there is
UI animation.

Comment 15

[Robert John Churchill]

Verbal sr=ben

Comment 16

[Asa Dotzler [:asa]]

Comment on attachment 72180 [details] [diff] [review]
Patch to remove modality (especially important for Mac OS X)

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 17

[Robert John Churchill]

Fixed.

Comment 18

[Tom Everingham]

verified:  03/25/02 trunk, winNT4, linux rh6, mac osX