Closed
Bug 1285877
Opened 8 years ago
Closed 8 years ago
Retain compatibility for iterator changes
Categories
(Calendar :: Provider: GData, defect)
Calendar
Provider: GData
Tracking
(Not tracked)
RESOLVED
FIXED
5.2
People
(Reporter: Fallen, Assigned: Fallen)
Details
Attachments
(1 file)
With bug 1098585 I introduced changes that require for...of which is not available in old versions. I don't think it is worth breaking compatibility for this, so this bug will patch it to not use propertyIterator.
|
Assignee | |
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/63426/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63426/
Attachment #8769602 -
Flags: review?(makemyday)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8769602 [details]
Bug 1285877 - Retain compatibility for iterator changes.
https://reviewboard.mozilla.org/r/63426/#review60296
I'd appreciate if we can return to bmo/splinter for reviews.
Attachment #8769602 -
Flags: review?(makemyday) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
Fair enough. I've just moved from mq to bookmarks, with which pushing to mozreview seemed very simple. But I acknowledge that mozreview is more cludgy and not as fast as doing the review in splinter. Also we unfortunately don't have autoland.
https://hg.mozilla.org/comm-central/rev/a0e15f635e05
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•8 years ago
|
Target Milestone: --- → 5.2
|
|
Assignee | |
Comment 4•8 years ago
|
||
|
|
Assignee | |
Comment 5•8 years ago
|
||
Comment on attachment 8769602 [details]
Bug 1285877 - Retain compatibility for iterator changes.
https://reviewboard.mozilla.org/r/63426/#review60598
Attachment #8769602 -
Flags: review+
You need to log in
before you can comment on or make changes to this bug.
Description
•