1285975 - product/channel filter not updated after adding a new rule or changing an existing one

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (frontend), defect)

Description

[[e-mail] (:bhearsum)]

The Product/Channel drop down on the rules page is supposed to contain a list of all of products, and the product+channel combinations. This works fine on initial page load, but is not updated if a new rule is added, nor an existing one modified. It's relatively rare that we add a new product or channel, but this is an annoying papercut.

Comment 1

[Njira]

Hi Ben.

I am unable to reproduce this bug. When I add a new Rule I can see it in the appropriate filtered rules list. And when I update a Rule from a filtered list it is automatically removed as a member of the filtered list. Please advise on what this bug might be or from what angle it is.

Comment 2

[[e-mail] (:bhearsum)]

(In reply to Njira from comment #1)
> Hi Ben.
> 
> I am unable to reproduce this bug. When I add a new Rule I can see it in the
> appropriate filtered rules list. And when I update a Rule from a filtered
> list it is automatically removed as a member of the filtered list. Please
> advise on what this bug might be or from what angle it is.

Everything works fine in the list of Rules themselves, but if you add or update a Rule to contain a new Product or Channel, that won't be available in the drop down. For example, I loaded the Rules page and added a rule with "AAA" as both the Product and Channel. Once added, the drop down in the top right did not change at all. When I reloaded the page, it add "AAA" and "AAA,AAA" entries in it.

Does that make sense?

Comment 3

[Njira]

Yes Ben I believe I understand. The dropdown should be updated to include new Product/Channel combinations.

Comment 4

[[e-mail] (:bhearsum)]

(In reply to Njira from comment #3)
> Yes Ben I believe I understand. The dropdown should be updated to include
> new Product/Channel combinations.

That's right.

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/a23096f36fa474ac8df6c83d8f5abbea7c04f605
bug 1285975: product/channel filter not updated after adding/editting (#188). r=bhearsum

Comment 6

[[e-mail] (:bhearsum)]

This is in production now, thanks Njira!