1286467 - add gdb pretty printer for nsTHashtable/nsBaseHashtable/friends

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Andrew Sutherland [:asuth] (he/him)]

Attachment: teaser example of printing the ServiceWorkerManager singleton and its many maps, two of which have stuff in this example dump

I have this working, patch coming in a moment, just want a bug number issued.  Note that I'm not sure this is the right component for this, but it's where bug 985566 lived that added the non-spidermonkey pretty printers.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Attachment: nsTHashtable pretty printer, v1

:froydnj seems unavailable for reviews right now, but as the author of the pretty printers, :tbsaunde, you seem like a pretty good pick too!

Comment 2

[Trevor Saunders (:tbsaunde)]

Comment on attachment 8770423 [details] [diff] [review]
nsTHashtable pretty printer, v1

I'm not feeling that great today, and I'm not sure I'm up to reviewing this much python anyway, so forwarding to Tromey.

Comment 3

[Tom Tromey :tromey]

Comment on attachment 8770423 [details] [diff] [review]
nsTHashtable pretty printer, v1

Review of attachment 8770423 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for doing this.

This looks good.  I had one minor nit.

::: python/gdbpp/gdbpp/thashtable.py
@@ +1,1 @@
> +# -*- Mode: python; c-basic-offset: 4; indent-tabs-mode: nil; tab-width: 40 -*-

I don't think c-basic-offset is needed here.
It doesn't affect python-mode.

I filed bug 1286877 to fix all the other instances of this in the tree.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f1350824e2ce
add gdb pretty printer for nsTHashtable/nsBaseHashtable/friends. r=tromey

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f1350824e2ce