Closed Bug 128669 Opened 23 years ago Closed 23 years ago

Sidebar panels should use <browser> not <iframe>

Categories

(SeaMonkey :: Sidebar, defect)

Product:
SeaMonkey
Component:
Sidebar
Platform:
x86
Windows 2000
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: bugzilla, Assigned: bugzilla)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

new patch - tested on mac and win. samir, please r.
965 bytes, patch
samir_bugzilla
: review+
bugs
: superreview+
brendan
: approval+
Details | Diff | Splinter Review
This used to just be a correctness thing, but now drag and drop code has been moved into C++, and it's automatically hooked up to <browser>. So it's necessary that the panels be converted so that drag and drop from sidebar panels works.
Attached patch patch (obsolete) — — Splinter Review
Comment on attachment 72276 [details] [diff] [review] patch marking r=sgehani since he agreed before he left.
Attachment #72276 - Flags: review+
Nominating for nsbeta1 because: * This is just the correct thing to do, we've always known it, but now we have a reason to do it (drag and drop stopped working in sidebar panels). * Browser is more than adequately tested -- it's the widget we use for navigator and for displaying mail messages! The risk is absolutely negligible.
Keywords: mozilla1.0, nsbeta1, regression
Comment on attachment 72276 [details] [diff] [review] patch sr=hewitt
Attachment #72276 - Flags: superreview+
Marking nsbeta1+
Keywords: nsbeta1 → nsbeta1+
Comment on attachment 72276 [details] [diff] [review] patch a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #72276 - Flags: approval+
Fixed.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
blake, please verify...thanks...
This can be verified by seeing if you can drag links from sidebar panels.
I just tried it in 3/11 trunk build on windows and I tried dragging links from various tabs, and they don't seem to drag. I dragged them into the browser main window, nothing happened.. REOPEN.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
er...works for me in a 3/11 build. you mean you can't even start dragging the links?
it does not work and we just got a new bug report filed. I will DUP that bug to this one...
forgot to answer blake's question. yes I can't even start dragging links.
*** Bug 130292 has been marked as a duplicate of this bug. ***
The person was using 0.9.9. It won't work in 099. Are you sure you're using a trunk build?
yes I'm using today's 3/12 trunk commercial build and I simply drag links from News/Shopping/Today'sTips tabs and they don't drag, and nothing drops in the main browser window...I drag links from the tabs and drop them into the browse window.
Verified: this bug exists in windows and linux builds from the trunk as of 21:40 PST.
I can reproduce this [1] with today's trunk build showing this user agent info in the about page: Mozilla 0.9.9+ Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.9+) Gecko/20020313 [1] That is, I can reproduce the inability to drag a link from the News or Tinderbox tab.
How could this work for me and no one else? Does anyone have winxp to test on?
Try this: 1) Create a new profile 2) Start mozilla with the new profile. Dragging works fine. 3) Change to the modern theme. Dragging still works fine. 4) Quit mozilla 5) Start mozilla again, with the just-created theme. 6) Dragging now broken
Dragging in classic works for me but dragging in modern fails. Blake, Can we either backout the last patch or address the problem in modern? Thanks.
There seems to be some confusion. Let me clarify that my patch did not *cause* the drag and drop problem! It fixed it in Classic, but not in Modern. And now I see the reason -- modern css binds the iframe-panel class to something else, so it's still not a browser in modern. Simple patch coming up.
Attachment #72276 - Attachment is obsolete: true
Comment on attachment 74412 [details] [diff] [review] new patch - tested on mac and win. samir, please r. r=sgehani assuming you have tested web and chrome tabs.
Attachment #74412 - Flags: review+
Verified that Blakes 2nd patch works on Win2k and Linux, modern skin
Comment on attachment 74412 [details] [diff] [review] new patch - tested on mac and win. samir, please r. sr=ben@netscape.com
Attachment #74412 - Flags: superreview+
Comment on attachment 74412 [details] [diff] [review] new patch - tested on mac and win. samir, please r. a=brendan@mozilla.org for 1.0 checkin. /be
Attachment #74412 - Flags: approval+
fixed.
Status: REOPENED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
verified in 3/19 build.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: