Followup from bug 1249494. Previous to that bug, the "Remote DNS" checkbox was next to the SOCKS 4/5 radio buttons. Which was confusing because it was selectively enabled / disabled depending on other selections in the UI (See bug 1249494 comment 12). We ended up just moving the checkbox to the bottom of the window, but didn't change when the checkbox is enabled/disabled (from bug 665319). Later comments in the bug (18, 20, 21) indicate that even the previous behavior was wrong -- sounds like it should apply to both SOCKS v4 and SOCKS v5, perhaps only when a manual proxy is selected, and other bugs (bug 468868, bug 474824) further complicate when it actually works. Happy to update the UI to reflect reality, but someone more familiar with the state of SOCKS needs to propose/verify what's needed.
I proposed to remove this hard-to-understand checkbox in bug 610896 comment #18. Note that this change does not have to wait until bug 610896 is fixed. The current back-end is already providing enough capability to implement this UI.
Sorry to ask but with regard to bug 1249494 and the current "Proxy DNS when using SOCKS v5" string as well as for future changes, can anyone verify that "Proxy" is used as a verb here? If so, it may be best to avoid that since "to proxy" may not be an official verb (more dev/tech talk), as well as hard to localize. I also noticed different (verb/noun) localizations for it already, possibly due to lack of context. Since I don’t think there is such thing as a "Proxy DNS" (well there is, but if that was intended here, one would expect to see a definition field for a DNS) and it’s a replacement for "Remote DNS", I see and tend to localize it as "DNS via/over proxy when using SOCKS v5", possibly prefixed by "query".
Yes, that sounds sensible. "Use Proxy for DNS queries in SOCKS v5" is my personal preference.
Can we be sure "Use proxy for DNS queries (with SOCKS v5)" will be used in 51a? If so, some localizers might want to use that for for 50a localizations instead of the current string in order to avoid 2 changes in a row, as well as Sumo instructions needing a specific string for 50 only.
While I had hoped the (final) string would have been fixed to match comment 5 in order to prevent a slightly negligent impression to users and localizers for the reasons above, it’s been a few weeks now and we’re currently in the 51a aurora cycle. Can anyone make a decision and let the fix land? Unless there is a good reason to wait, of course.
What's needed here is for someone familiar with the code to propose and verify what the correct language for this pref should be. (And perhaps block on some followup fixes, to make the behavior sane, if it's too difficult to accurately and succinctly describe in the UI.) Removing it entirely is also an option (comment 2), if the module owner is ok with that.
Considering the 57 cycle and it preferences reorg, I wonder if it would be good/possible to include this rewording?
"Send DNS queries through the proxy when using SOCKS v5"?