1292899 - Clearer label for Proxy DNS preference

Status: RESOLVED DUPLICATE of bug 1286701

(Firefox :: Settings UI, defect, P3)

Description

[Manish Goregaokar [:manishearth]]

See bug 1286701 comment 2. The current label ("Proxy DNS when using SOCKS v5") is confusing (Proxy isn't really a verb), and localizations are getting messed up.

Comment 1

[Manish Goregaokar [:manishearth]]

Oh, this isn't the current label, just the proposed label

Comment 2

[Manish Goregaokar [:manishearth]]

Heh, I was wrong. Misread the comments.

Comment 3

[Manish Goregaokar [:manishearth]]

Attachment: Bug 1292899 - Clearer label for remote DNS preference;

Review commit: https://reviewboard.mozilla.org/r/69822/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69822/

Comment 4

[Matthew N. [:MattN]]

Comment on attachment 8778587 [details]
Bug 1292899 - Clearer label for remote DNS preference;

https://reviewboard.mozilla.org/r/69822/#review69298

Can you explain how this bug is different than bug 1286701? It's not clear to me that the "SOCKS v5" part of the string is correct and I'm not sure it makes sense to have churn again on the string once the purpose of the checkbox is fully understood. If you want to proceed with something in this bug please flag dolske for review as he seems to have more context about the problems of this UI.

::: browser/locales/en-US/chrome/browser/preferences/connection.dtd:35
(Diff revision 1)
>  <!ENTITY  socks.accesskey               "C">
>  <!ENTITY  socks4.label                  "SOCKS v4">
>  <!ENTITY  socks4.accesskey              "K">
>  <!ENTITY  socks5.label                  "SOCKS v5">
>  <!ENTITY  socks5.accesskey              "v">
> -<!ENTITY  socksRemoteDNS.label2         "Proxy DNS when using SOCKS v5">
> +<!ENTITY  socksRemoteDNS.label2         "Use proxy for DNS queries (with SOCKS v5)">

You need to change the string identifier whenever you change a string so that it gets re-localized.

Comment 5

[Manish Goregaokar [:manishearth]]

This was just about making the existing text clearer (without changing the meaning). But yeah, I guess we should just fix bug 1286701.