1287054 - Support all level 3 CSS length units in SVG

Status: RESOLVED FIXED

(Core :: SVG, enhancement, P3)

Description

[Sebastian Zartner [:sebo]]

SVG 2 defines that all units in SVG follow the description and definition of common values and units from the CSS Values and Units Module[1].

Therefore the viewport-percentage length units 'vw', 'vh', 'vi', 'vb', 'vmin' and 'vmax' should also have an effect within SVG.

There is also an issue[2] discussing to which viewport those units refer.

Sebastian

[1] https://drafts.csswg.org/css-values-3/#viewport-relative-lengths
[2] https://github.com/w3c/svgwg/issues/207

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Chrome supports this now: https://bugs.chromium.org/p/chromium/issues/detail?id=368598#c11

Comment 2

[Karl Dubost💡 :karlcow]

This is a followup on https://webcompat.com/issues/12853

<svg height="100vh" width="100vw" 
     viewbox="0 0 100 100">
  <circle cx="50" cy="50" r="40" 
     fill="red" />
</svg>


It was in Chromium (Blink) a while ago
https://bugs.chromium.org/p/chromium/issues/detail?id=368598#c11

found out also that WebKit is reporting that this is an invalid attribute BUT still applies the transformation.
In WebKit, for the implementation of viewport lengths, but not specific to SVG.
https://bugs.webkit.org/show_bug.cgi?id=27160

or maybe WebKit doesn't support it but fallback on 100% when there is a parsing error and it's why it is working. Ah no. 
<svg  id="f" style="height:10vh; width:10vw;" viewbox="0 0 100 100"> is working as expected.

Comment 3

[violet.bugreport]

We should implement:

1. vw, vh, vmin, vmax
2. q
3. rem, ch

Note vi and vb are in CSS level 4, they are not supported in any browser yet. It won't be implemented here either.

Comment 4

[violet.bugreport]

Attachment: Bug 1287054 - Implement vw, vh, vmin, vmax, q, rem, ch as SVG units

We should support all CSS units.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:jwatt, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 10

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=73553de5a6c86e41a584038f18875b2f0f25272a

Comment 11

[Robert Longson [:longsonr]]

Attachment: Bug 1287054 part 1 - support rem, ch, ic and cap units for non-CSS lengths r=emilio

Comment 12

[Robert Longson [:longsonr]]

Attachment: Bug 1287054 part 2 - support vw, vh, vmin and vmax units for non-CSS lengths r=emilio

Depends on D180618

Comment 13

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=2d93ada3c303090f6d04f32a9c0b678912874bed

Comment 14

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=311c2a0fe763142742f5c45f4231a09c677e05bd

Comment 15

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=7ff365f76ef40b21b3a3b7d7b16db3cafc22312b

Comment 16

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=03889ef904984ba7ccae1783cf1a14e1a74404d2

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35034282dc7c
part 1 - support rem, ch, ic and cap units for non-CSS lengths r=emilio,jgilbert
https://hg.mozilla.org/integration/autoland/rev/5158484e9eab
part 2 - support vw, vh, vmin and vmax units for non-CSS lengths r=emilio,jgilbert

Comment 18

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/41914 for changes under testing/web-platform/tests

Comment 19

[Serban Stanca [:SerbanS]]

Backed out for causing build bustages in SVGAnimatedLength.cpp.

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/dom/svg/SVGAnimatedLength.cpp:197:1: error: control reaches end of non-void function [-Werror=return-type]

Comment 20

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 21

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=8873e10aeb6f2e38abd34f79de63a469882adcfd&selectedTaskRun=GiYzGXGRT5Scx9BhAsfPmQ.0

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a94c155e35c
part 1 - support rem, ch, ic and cap units for non-CSS lengths r=emilio,jgilbert
https://hg.mozilla.org/integration/autoland/rev/fc8eaef017f9
part 2 - support vw, vh, vmin and vmax units for non-CSS lengths r=emilio,jgilbert

Comment 23

[Serban Stanca [:SerbanS]]

Backed out for causing Android wpt failures in SVGLength-ch.html

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | /svg/types/scripted/SVGLength-ch.html | ch unit in SVGLength - assert_equals: expected 112 but got 112.33333587646484

There are failures on Windows too -> link.

Comment 24

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 25

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=f0c5ea8210e849ad23d091527522f889fc9517ff - despite the sea of orange there's nothing that could be caused by these patches.

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f48a6566514
part 1 - support rem, ch, ic and cap units for non-CSS lengths r=emilio,jgilbert
https://hg.mozilla.org/integration/autoland/rev/4cca882e069d
part 2 - support vw, vh, vmin and vmax units for non-CSS lengths r=emilio,jgilbert

Comment 27

[Sandor Molnar[:smolnar]]

Backed out for causing wpt failures in svg/types/scripted/SVGLength-ch.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/dea68b5e89ef3995691a045ed59e46834e5ce778

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | /svg/types/scripted/SVGLength-ch.html | Convert back to ch from new user unit value - assert_equals: expected 40 but got 39.88

Comment 28

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=a966d3d24e09f9609de17556c1f9b09d1809652f hard to tell but I can't find anything in that sea of orange that's mine.

Comment 29

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a16d763f2866
part 1 - support rem, ch, ic and cap units for non-CSS lengths r=emilio,jgilbert
https://hg.mozilla.org/integration/autoland/rev/9525c5d9a710
part 2 - support vw, vh, vmin and vmax units for non-CSS lengths r=emilio,jgilbert

Comment 30

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/a16d763f2866
https://hg.mozilla.org/mozilla-central/rev/9525c5d9a710

Comment 32

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 33

[Dave Letorey]

• Content PR