Closed
Bug 1287080
Opened 8 years ago
Closed 8 years ago
Move Toolbar, Frame and Gripper widgets to WidgetCache
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: stransky, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
13.55 KB,
patch
|
acomminos
:
review-
|
Details | Diff | Splinter Review |
15.97 KB,
patch
|
acomminos
:
review+
|
Details | Diff | Splinter Review |
Let's move other widgets to WidgetCache and use them in other widget code.
Reporter | ||
Updated•8 years ago
|
Summary: Move Toolbar widgets to WidgetCache → Move Toolbar, Frame and Gripper widgets to WidgetCache
Reporter | ||
Comment 1•8 years ago
|
||
There's the patch, Thanks!
Attachment #8771381 -
Flags: review?(andrew)
Comment 2•8 years ago
|
||
Comment on attachment 8771381 [details] [diff] [review] patch Review of attachment 8771381 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, just a few things: ::: widget/gtk/WidgetStyleCache.cpp @@ +168,5 @@ > > static GtkWidget* > +CreateFrameWidget() > +{ > + GtkWidget* widget = gtk_frame_new(NULL); Prefer nullptr. ::: widget/gtk/gtk3drawing.cpp @@ -972,5 @@ > - gtk_widget_set_direction(gHandleBoxWidget, direction); > - > - style = gtk_widget_get_style_context(gHandleBoxWidget); > - gtk_style_context_save(style); > - gtk_style_context_add_class(style, GTK_STYLE_CLASS_GRIP); It doesn't look like GTK adds this style class to the widget upon initialization, unlike GTK_STYLE_CLASS_TOOLBAR- should we be setting it? GTK 3.4 seems to check for it in gtkthemingengine.c, and sets it on a window's grip.
Attachment #8771381 -
Flags: review?(andrew) → review-
Reporter | ||
Comment 3•8 years ago
|
||
Good catch, Thanks. There's updated one with GRIPPER style set. It's also checked on 3.20 - we may convert it to CSS nodes later. Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=40ccfa60ea9b
Attachment #8771953 -
Flags: review?(andrew)
Comment 4•8 years ago
|
||
Comment on attachment 8771953 [details] [diff] [review] patch v.2 Review of attachment 8771953 [details] [diff] [review]: ----------------------------------------------------------------- Great, thanks!
Attachment #8771953 -
Flags: review?(andrew) → review+
Reporter | ||
Updated•8 years ago
|
Keywords: checkin-needed
Reporter | ||
Comment 5•8 years ago
|
||
Comment on attachment 8771953 [details] [diff] [review] patch v.2 Note: check-in a patch from Bug 1287082 before this one.
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f4320d509686 Move Toolbar, Frame and Gripper widgets from gtk3drawing to WidgetCache, r=acomminos
Keywords: checkin-needed
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f4320d509686
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•