If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[pine => m-c] Transition bootstrapping

RESOLVED FIXED

Status

Firefox OS
General
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: gerard, Assigned: gerard)

Tracking

unspecified
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(firefox50 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 2 obsolete attachments)

Comment hidden (empty)
(Assignee)

Updated

a year ago
Depends on: 1252371
(Assignee)

Updated

a year ago
Depends on: 1256506
(Assignee)

Updated

a year ago
Depends on: 1259094, 1260873, 1260992
(Assignee)

Updated

a year ago
Depends on: 1274966
(Assignee)

Comment 1

a year ago
Created attachment 8771414 [details]
Bug 1287107 - Making transition alive with gaia as chrome://

Conflicts:
	b2g/chrome/content/shell.js
	dom/apps/PermissionsTable.jsm
	dom/system/gonk/AudioChannelManager.cpp
	js/xpconnect/src/nsXPConnect.cpp

Review commit: https://reviewboard.mozilla.org/r/64586/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64586/
(Assignee)

Comment 2

a year ago
Created attachment 8771415 [details]
Bug 1287107 - Move gaia to chrome:// URLs r?

Review commit: https://reviewboard.mozilla.org/r/64588/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64588/
(Assignee)

Comment 3

a year ago
Created attachment 8771416 [details]
Bug 1287107 - Allow experimental ECMA formatToParts in chrome

Review commit: https://reviewboard.mozilla.org/r/64590/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64590/
(Assignee)

Comment 4

a year ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=26323aaeeded
(Assignee)

Updated

a year ago
Depends on: 1254501
(Assignee)

Comment 5

a year ago
Comment on attachment 8771414 [details]
Bug 1287107 - Making transition alive with gaia as chrome://

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64586/diff/1-2/
Attachment #8771414 - Attachment description: Bug 1287107 - Bootstrap the transition r? → Bug 1287107 - Making transition alive with gaia as chrome://
Attachment #8771416 - Attachment description: Bug 1287107 - Allow experimental ECMA formatToParts in chrome r? → Bug 1287107 - Allow experimental ECMA formatToParts in chrome
Attachment #8771414 - Flags: review?(fabrice)
Attachment #8771414 - Flags: review?(bobbyholley)
Attachment #8771416 - Flags: review?(bobbyholley)
(Assignee)

Comment 6

a year ago
Comment on attachment 8771416 [details]
Bug 1287107 - Allow experimental ECMA formatToParts in chrome

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64590/diff/1-2/
(Assignee)

Updated

a year ago
Attachment #8771415 - Attachment is obsolete: true
(Assignee)

Comment 7

a year ago
Bobby, we require your review on those two patches for the js/xpconnect/src/nsXPConnect.cpp changes :)
(Assignee)

Comment 8

a year ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9e8ff4a59d58
Attachment #8771414 - Flags: review?(bobbyholley) → review+
Comment on attachment 8771414 [details]
Bug 1287107 - Making transition alive with gaia as chrome://

https://reviewboard.mozilla.org/r/64586/#review62268

Assuming previously-certified-app is something that only gets set for gaia stuff, this is fine.
(specifically the nsXPConnect.cpp change).
Comment on attachment 8771416 [details]
Bug 1287107 - Allow experimental ECMA formatToParts in chrome

https://reviewboard.mozilla.org/r/64590/#review62270

I'm less sure we want this. I don't know anything about this API, but in general exposing APIs to chrome has a real cost, especially if addons start using it. Seems like we probably want jorendorff to tell us whether this should be exposed in its current form.
Attachment #8771416 - Flags: review?(bobbyholley)
(Assignee)

Comment 12

a year ago
We would need your opinion regarding comment 11 :)
Flags: needinfo?(jorendorff)
(Assignee)

Comment 13

a year ago
Technically, formatToParts() is needed for lockscreen & l20n code, I guess that we could land the first big patch. Of course that would break parts of Gaia; but it's manageable.
Flags: needinfo?(bobbyholley)
(Assignee)

Comment 14

a year ago
Comment on attachment 8771414 [details]
Bug 1287107 - Making transition alive with gaia as chrome://

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64586/diff/2-3/
Attachment #8771416 - Flags: review?(jorendorff)
(Assignee)

Comment 15

a year ago
Comment on attachment 8771416 [details]
Bug 1287107 - Allow experimental ECMA formatToParts in chrome

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64590/diff/2-3/
Comment on attachment 8771414 [details]
Bug 1287107 - Making transition alive with gaia as chrome://

https://reviewboard.mozilla.org/r/64586/#review63118
Attachment #8771414 - Flags: review?(fabrice) → review+
(Assignee)

Updated

a year ago
Blocks: 1288653
(Assignee)

Updated

a year ago
Attachment #8771416 - Attachment is obsolete: true
Attachment #8771416 - Flags: review?(jorendorff)

Comment 17

a year ago
Pushed by alissy@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/16aa7041c009
Making transition alive with gaia as chrome:// r=bholley,fabrice
backed this out since it seems this caused https://treeherder.mozilla.org/logviewer.html#?job_id=882302&repo=autoland
Flags: needinfo?(lissyx+mozillians)

Comment 19

a year ago
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/35921a0c3857
Backed out changeset 16aa7041c009 for causing xpcshell and mac tests
(Assignee)

Updated

a year ago
Flags: needinfo?(lissyx+mozillians)
(Assignee)

Comment 20

a year ago
Strange, this was green before: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9e8ff4a59d58
(Assignee)

Comment 21

a year ago
Ah maybe it is because some of permissions changes were in the second patch. We will see the current try :)
(Assignee)

Comment 22

a year ago
Comment on attachment 8771414 [details]
Bug 1287107 - Making transition alive with gaia as chrome://

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64586/diff/3-4/
(Assignee)

Comment 23

a year ago
previous set of patches: https://treeherder.mozilla.org/#/jobs?repo=try&revision=df92dd0c3da0
new set of patches:      https://treeherder.mozilla.org/#/jobs?repo=try&revision=c97ae533d769
new current patch only:  https://treeherder.mozilla.org/#/jobs?repo=try&revision=a78c68024c53
(Assignee)

Updated

a year ago
Flags: needinfo?(jorendorff)
Flags: needinfo?(bobbyholley)
(Assignee)

Comment 24

a year ago
Ok, moved part of the formatToParts() patch to this one, fixing the permission manager issues: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a78c68024c53

Comment 25

a year ago
Pushed by alissy@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6776f3d11ac4
Making transition alive with gaia as chrome:// r=bholley,fabrice

Comment 26

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6776f3d11ac4
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.