Closed Bug 1287107 Opened 3 years ago Closed 3 years ago

[pine => m-c] Transition bootstrapping

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(firefox50 fixed)

RESOLVED FIXED
Tracking Status
firefox50 --- fixed

People

(Reporter: gerard-majax, Assigned: gerard-majax)

References

Details

Attachments

(1 file, 2 obsolete files)

No description provided.
Depends on: 1252371
Depends on: 1256506
Depends on: 1259094, 1260873, 1260992
Depends on: 1274966
Conflicts:
	b2g/chrome/content/shell.js
	dom/apps/PermissionsTable.jsm
	dom/system/gonk/AudioChannelManager.cpp
	js/xpconnect/src/nsXPConnect.cpp

Review commit: https://reviewboard.mozilla.org/r/64586/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64586/
Depends on: 1254501
Comment on attachment 8771414 [details]
Bug 1287107 - Making transition alive with gaia as chrome://

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64586/diff/1-2/
Attachment #8771414 - Attachment description: Bug 1287107 - Bootstrap the transition r? → Bug 1287107 - Making transition alive with gaia as chrome://
Attachment #8771416 - Attachment description: Bug 1287107 - Allow experimental ECMA formatToParts in chrome r? → Bug 1287107 - Allow experimental ECMA formatToParts in chrome
Attachment #8771414 - Flags: review?(fabrice)
Attachment #8771414 - Flags: review?(bobbyholley)
Attachment #8771416 - Flags: review?(bobbyholley)
Comment on attachment 8771416 [details]
Bug 1287107 - Allow experimental ECMA formatToParts in chrome

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64590/diff/1-2/
Attachment #8771415 - Attachment is obsolete: true
Bobby, we require your review on those two patches for the js/xpconnect/src/nsXPConnect.cpp changes :)
Attachment #8771414 - Flags: review?(bobbyholley) → review+
Comment on attachment 8771414 [details]
Bug 1287107 - Making transition alive with gaia as chrome://

https://reviewboard.mozilla.org/r/64586/#review62268

Assuming previously-certified-app is something that only gets set for gaia stuff, this is fine.
(specifically the nsXPConnect.cpp change).
Comment on attachment 8771416 [details]
Bug 1287107 - Allow experimental ECMA formatToParts in chrome

https://reviewboard.mozilla.org/r/64590/#review62270

I'm less sure we want this. I don't know anything about this API, but in general exposing APIs to chrome has a real cost, especially if addons start using it. Seems like we probably want jorendorff to tell us whether this should be exposed in its current form.
Attachment #8771416 - Flags: review?(bobbyholley)
We would need your opinion regarding comment 11 :)
Flags: needinfo?(jorendorff)
Technically, formatToParts() is needed for lockscreen & l20n code, I guess that we could land the first big patch. Of course that would break parts of Gaia; but it's manageable.
Flags: needinfo?(bobbyholley)
Comment on attachment 8771414 [details]
Bug 1287107 - Making transition alive with gaia as chrome://

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64586/diff/2-3/
Attachment #8771416 - Flags: review?(jorendorff)
Comment on attachment 8771416 [details]
Bug 1287107 - Allow experimental ECMA formatToParts in chrome

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64590/diff/2-3/
Comment on attachment 8771414 [details]
Bug 1287107 - Making transition alive with gaia as chrome://

https://reviewboard.mozilla.org/r/64586/#review63118
Attachment #8771414 - Flags: review?(fabrice) → review+
Blocks: 1288653
Attachment #8771416 - Attachment is obsolete: true
Attachment #8771416 - Flags: review?(jorendorff)
Pushed by alissy@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/16aa7041c009
Making transition alive with gaia as chrome:// r=bholley,fabrice
backed this out since it seems this caused https://treeherder.mozilla.org/logviewer.html#?job_id=882302&repo=autoland
Flags: needinfo?(lissyx+mozillians)
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/35921a0c3857
Backed out changeset 16aa7041c009 for causing xpcshell and mac tests
Flags: needinfo?(lissyx+mozillians)
Ah maybe it is because some of permissions changes were in the second patch. We will see the current try :)
Comment on attachment 8771414 [details]
Bug 1287107 - Making transition alive with gaia as chrome://

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64586/diff/3-4/
Flags: needinfo?(jorendorff)
Flags: needinfo?(bobbyholley)
Ok, moved part of the formatToParts() patch to this one, fixing the permission manager issues: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a78c68024c53
Pushed by alissy@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6776f3d11ac4
Making transition alive with gaia as chrome:// r=bholley,fabrice
https://hg.mozilla.org/mozilla-central/rev/6776f3d11ac4
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.