1287110 - perfherder alerts show reassigned values, but they are incorrect

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

I am excited to see that the perfherder alerts are now showing what alert they are downstreamed/reassigned to, for example:
https://treeherder.mozilla.org/perf.html#/graphs?timerange=7776000&series=%5Bmozilla-beta,52106bc4092c8291f271bccd6ce31bd9111bfb71,1,1%5D&series=%5Bmozilla-aurora,52106bc4092c8291f271bccd6ce31bd9111bfb71,1,1%5D&highlightedRevisions=84c59d136a9e&highlightedRevisions=709652b67401&zoom=1464981645273.7126,1465468785626.0164,846.5923323507204,1143.9901018674489&selected=%5Bmozilla-aurora,52106bc4092c8291f271bccd6ce31bd9111bfb71,13292,2764943,1%5D

I see:
sessionrestore (mozilla-aurora)
osx-10-10
1034
Δ 49.0 (5.0%)
cea65ca3d0bd (job, compare)
Alert #1485 - reassigned to alert #1493 

clicking on alert 1493 doesn't show any sessionrestore data, but clicking on alert 1485, I see the specific alert is reassigned to alert 1603.

this needs to be accurate to be useful.

Comment 1

[William Lachance (:wlach)]

Hi Shruti, so I realized that there was a minor problem with your changes in bug 1260010: for looking up the related_summary_id parameter, we need to look at the *specific* alert contained in the summary, not just the first alert in the summary (which most likely does not pertain to the series we're looking at). Gonna assume you're ok with looking into this.

I think we need to look up the actual alert and then use it in the dialog. You should be able to do so with something like this (untested, I'm not sure whether phSeries is the right variable but am pretty sure it is):

var alert = _.find(alertSummary.alerts, function(alert) { return alert.series_signature.signature_hash === phSeries.signatureHash; })

You'll do that around here: https://github.com/mozilla/treeherder/blob/7b08f1e916ba62574eed5f92aa506aa5de25250a/ui/js/controllers/perf/graphs.js#L125

I'll leave it up to you to add the code to pass the information to the partial (it's in the same areas as you touched in bug 1260010).

A simplified test case is here (just replace 'https://treeherder.mozilla.org' with 'http://localhost:8000' to use your node webserver):

https://treeherder.mozilla.org/perf.html#/graphs?timerange=7776000&series=%5Bmozilla-aurora,52106bc4092c8291f271bccd6ce31bd9111bfb71,1,1%5D&highlightedRevisions=84c59d136a9e&highlightedRevisions=709652b67401&zoom=1464981645273.7126,1465468785626.0164,846.5923323507204,1143.9901018674489&selected=%5Bmozilla-aurora,52106bc4092c8291f271bccd6ce31bd9111bfb71,13292,2764943,1%5D

Comment 2

[Shruti Jasoria [:ShrutiJ]]

Sure, I'll take up this bug. :)

Comment 3

[GitHub Autolander Bot]

Attachment: [treeherder] SJasoria:Bug_1287110 > mozilla:master

Comment 4

[Shruti Jasoria [:ShrutiJ]]

Comment on attachment 8771666 [details] [review]
[treeherder] SJasoria:Bug_1287110 > mozilla:master

I have made a few changes. They seem to work well locally. :)

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/4b13b6febba2b0ced48e09ead08711fcae684075
Bug 1287110 - Show correct reassigned alert number in Perfherder graphs

Comment 6

[William Lachance (:wlach)]

Comment on attachment 8771666 [details] [review]
[treeherder] SJasoria:Bug_1287110 > mozilla:master

Patch looks great except for commit message (which I corrected, see PR). Thanks!!