1287159 - onCommand listeners do not grant the activeTab permisson to the current tab

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect, P1)

Description

[zmstefan]

Attachment: fillzToAmazon.xpi

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.103 Safari/537.36

Steps to reproduce:

I'm creating an WebExtension. I want to inject javascript to two different urls, one .js file per URL.
I manage to do this with chrome.browserAction.onClicked, so when I click on button on toolbar it works correctly.
But when I assign an shortcut to extension, and assign the same code for injecting .js to the onCommand event listener, it does not work, and outputs "No matching window" error in Console. I inject javascript into active tab with executeScript function.


Actual results:

^^


Expected results:

^^

Comment 1

[zmstefan]

Added <"all_urls"> to permissions in manifest.json file, and it's working as it should!

Comment 3

[Will Bamberg [:wbamberg]]

I'm not sure if this should be made a duplicate of bug 1274871. I haven't confirmed this bug, but it looks as if what's happening is that Firefox is not treating a hotkey combination as an "explicit user action", that then lets the "activeTab" permission do its thing. That would explain why the same code worked with a browser action.

I would have expected that a hotkey combination *should* be treated as a user action, and the Chrome docs for activeTab confirm this: https://developer.chrome.com/extensions/activeTab.

In short: Stefan should be able to use "activeTab" here. Using "<all_urls>" is a workaround for that bug.

Comment 4

[Kris Maglione [:kmag]]

Ah, sorry, you're right

Comment 5

[Matthew Wein [:mattw]]

Attachment: Bug 1287159 - Grant activeTab permission to the current tab when onCommand fires.

Review commit: https://reviewboard.mozilla.org/r/66960/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66960/

Comment 6

[Kris Maglione [:kmag]]

Comment on attachment 8774538 [details]
Bug 1287159 - Grant activeTab permission to the current tab when onCommand fires.

https://reviewboard.mozilla.org/r/66960/#review63828

This is a good start, but we also need tests. Please add at least one or two to browser_ext_tabs_executeScript_good.js, and probably one to browser_ext_tabs_executeScript_bad.js as well.

Comment 7

[Matthew Wein [:mattw]]

Comment on attachment 8774538 [details]
Bug 1287159 - Grant activeTab permission to the current tab when onCommand fires.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/66960/diff/1-2/

Comment 8

[Kris Maglione [:kmag]]

Comment on attachment 8774538 [details]
Bug 1287159 - Grant activeTab permission to the current tab when onCommand fires.

https://reviewboard.mozilla.org/r/66960/#review65128

Perfect. Thanks!

Comment 9

[Matthew Wein [:mattw]]

Comment on attachment 8774538 [details]
Bug 1287159 - Grant activeTab permission to the current tab when onCommand fires.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/66960/diff/2-3/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/9e0cbff9c4e1
Grant activeTab permission to the current tab when onCommand fires. r=kmag

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9e0cbff9c4e1