1387506 - activeTab permission not granted in commands API for command "_execute_browser_action"

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P2)

Description

[Rob Wu [:robwu]]

The activeTab permission is not applied when the special _execute_browser_action command triggers the browser.browserAction.onClicked event. The fix for bug 1287159 is thus incomplete.

Steps to reproduce:
1. Install #Display Anchors version 1.3 @ https://addons.mozilla.org/en-US/firefox/addon/display-_anchors/versions/?page=1#version-1.3
2. Open a page, e.g. https://github.com/Rob--W/display-anchors/issues/3
3. Press the extension button in the toolbar.
4. Reload the page (to clear any activeTab permission).
5. Press Ctrl-Shift-A.


Expected result:
Step 3 and 5 should enable the activeTab permission (According to https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/permissions#activeTab_permission).
The extension will inject a content script with chrome.tabs.executeScript that toggles the visibility of blue text.

- After step 3, blue text becomes visible.
- After step 5, blue text is hidden.


Actual result:
- After step 5, a notifications appears that shows that access has been denied (this shows that activeTab did not work).
- If step 4 is omitted, then the expected result occurs, because the activeTab permission from step 3 is still active (thus the bug that prevents activeTab from being applied correctly in step 5 does not affect the extension's functionality).

Comment 1

[Rob Wu [:robwu]]

Attachment: Bug 1387506 - Apply activeTab permission for _execute_browser_action

And add tests to confirm that activeTab works for both
_execute_browser_action and _execute_page_action.

Review commit: https://reviewboard.mozilla.org/r/164986/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/164986/

Comment 2

[Kris Maglione [:kmag]]

Comment on attachment 8893921 [details]
Bug 1387506 - Apply activeTab permission for _execute_browser_action

https://reviewboard.mozilla.org/r/164986/#review172894

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78541ddae4ab
Apply activeTab permission for _execute_browser_action r=kmag

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/78541ddae4ab